Skip to content

skip PDF export for s390x in jupyter minimal (3.11/3.12) #1329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: rhoai-2.23-multi-arch-poc
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ci/cached-builds/gen_gha_matrix_jobs.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@
S390X_COMPATIBLE = {
"runtime-minimal-ubi9-python-3.11",
"runtime-minimal-ubi9-python-3.12",
"jupyter-minimal-ubi9-python-3.11",
"jupyter-minimal-ubi9-python-3.12",
# add more here
}

Expand Down
6 changes: 6 additions & 0 deletions jupyter/utils/install_pdf_deps.sh
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,12 @@ if [[ -z "${ARCH:-}" ]]; then
exit 1
fi

# Skip PDF export installation for s390x architecture
if [[ "${ARCH}" == "s390x" ]]; then
echo "PDF export functionality is not supported on s390x architecture. Skipping installation."
exit 0
fi

# tex live installation
echo "Installing TexLive to allow PDf export from Notebooks"
curl -fL https://mirror.ctan.org/systems/texlive/tlnet/install-tl-unx.tar.gz -o install-tl-unx.tar.gz
Expand Down
8 changes: 8 additions & 0 deletions tests/containers/workbenches/jupyterlab/jupyterlab_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,14 @@ def test_spinner_html_loaded(self, jupyterlab_image: conftest.Image) -> None:
@allure.description("Check that PDF export is working correctly")
def test_pdf_export(self, jupyterlab_image: conftest.Image) -> None:
container = WorkbenchContainer(image=jupyterlab_image.name, user=4321, group_add=[0])
# Skip if we're running on s390x architecture
container.start(wait_for_readiness=False)
try:
exit_code, arch_output = container.exec(["uname", "-m"])
if exit_code == 0 and arch_output.decode().strip() == "s390x":
pytest.skip("PDF export functionality is not supported on s390x architecture")
finally:
docker_utils.NotebookContainer(container).stop(timeout=0)
test_file_name = "test.ipybn"
test_file_content = """{
"cells": [
Expand Down
Loading