Skip to content

Conversation

jiridanek
Copy link
Member

No description provided.

… by replacing manual installations with `dnf` package installation
Copy link

openshift-ci bot commented Aug 18, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@jiridanek
Copy link
Member Author

/build-konflux

Copy link

openshift-ci bot commented Aug 18, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign harshad16 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📋 Review Summary

This pull request simplifies the installation of PDF dependencies by replacing manual installation steps with a dnf command. This is a great improvement for maintainability and clarity.

🔍 General Feedback

  • The change is well-implemented and makes the script much easier to understand.
  • I've left one minor suggestion to sort the packages for even better readability.

Overall, this is a solid improvement.

texlive-txfonts \
texlive-ulem \
texlive-upquote \
texlive-utopia \

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 For better readability and easier maintenance, consider sorting the packages alphabetically.

Copy link

There is a problem with the Gemini CLI PR review. Please check the action logs for details.

@jiridanek
Copy link
Member Author

well, first attempt not good, konflux is not subscribed

+ dnf install -y pandoc texlive-adjustbox texlive-bibtex texlive-charter texlive-ec texlive-euro texlive-eurosym texlive-fpl texlive-jknapltx texlive-knuth-local texlive-lm-math texlive-marvosym texlive-mathpazo texlive-mflogo-font texlive-parskip texlive-plain texlive-pxfonts texlive-rsfs texlive-tcolorbox texlive-times texlive-titling texlive-txfonts texlive-ulem texlive-upquote texlive-utopia texlive-wasy texlive-wasy-type1 texlive-wasysym texlive-xetex
Updating Subscription Management repositories.
Unable to read consumer identity

This system is not registered with an entitlement server. You can use subscription-manager to register.

Red Hat Universal Base Image 9 (RPMs) - BaseOS  7.6 MB/s | 588 kB     00:00    
Red Hat Universal Base Image 9 (RPMs) - AppStre  21 MB/s | 2.4 MB     00:00    
Red Hat Universal Base Image 9 (RPMs) - CodeRea 4.1 MB/s | 287 kB     00:00    
No match for argument: pandoc
No match for argument: texlive-adjustbox
No match for argument: texlive-bibtex

@jiridanek
Copy link
Member Author

/build-konflux

@jiridanek
Copy link
Member Author

+ subscription-manager refresh
This system is not yet registered. Try 'subscription-manager register --help' for more information.
subprocess exited with status 1
subprocess exited with status 1

…r` repo and remove `subscription-manager refresh`
@jiridanek
Copy link
Member Author

/build-konflux

@jiridanek
Copy link
Member Author

[3/4] STEP 8/12: RUN ./utils/install_pdf_deps.sh
+ subscription-manager repos --enable codeready-builder-for-rhel-9-x86_64-rpms
This system has no repositories available through subscriptions.

@jiridanek
Copy link
Member Author

elif [ "${HERMETIC}" != "true" ] && find /entitlement -name "*.pem" >>null; then
  cp -r --preserve=mode "$ENTITLEMENT_PATH" /tmp/entitlement
  VOLUME_MOUNTS+=(--volume /tmp/entitlement:/etc/pki/entitlement)
  echo "Adding the entitlement to the build"
fi
[2025-08-18T16:07:56,554885353+00:00] Register sub-man
Adding the entitlement to the build
[2025-08-18T16:07:56,558691204+00:00] Add secrets
[2025-08-18T16:07:56,566623283+00:00] Run buildah build
[2025-08-18T16:07:56,567581674+00:00] buildah build --volume /tmp/entitlement:/etc/pki/entitlement --security-opt=unmask=/proc/interrupts --label build-date=2025-08-18T16:07:56 --label architecture=x86_64 --label vcs-type=git --label vcs-ref=58f38a074851285873c973a69bdd0ecc90ea7d08 --label quay.expires-after=5d --label version=on-pr-58f38a074851285873c973a69bdd0ecc90ea7d08 --label io.openshift.tags=odh-workbench-jupyter-datascience-cpu-py311 --label url=https://github.com/jiridanek/notebooks --label release=1755533003 --label git.url=https://github.com/jiridanek/notebooks --label git.commit=58f38a074851285873c973a69bdd0ecc90ea7d08 --tls-verify=true --no-cache --ulimit nofile=4096:4096 -f /tmp/Dockerfile.konflux.cpu.VGE957 -t quay.io/rhoai/pull-request-pipelines:notebooks-58f38a074851285873c973a69bdd0ecc90ea7d08-linux-x86-64 . 

@jiridanek
Copy link
Member Author

/build-konflux

@jiridanek
Copy link
Member Author

26 files removed
[1/2] STEP 5/9: RUN subscription-manager refresh
This system is not yet registered. Try 'subscription-manager register --help' for more information.
subprocess exited with status 1
subprocess exited with status 1
Error: building at STEP "RUN subscription-manager refresh": exit status 1

@openshift-merge-robot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants