-
Notifications
You must be signed in to change notification settings - Fork 20
RHAIENG-XXX: simplify PDF dependencies setup in install_pdf_deps.sh
by replacing manual installations with dnf
package installation
#1494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
… by replacing manual installations with `dnf` package installation
Skipping CI for Draft Pull Request. |
/build-konflux |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📋 Review Summary
This pull request simplifies the installation of PDF dependencies by replacing manual installation steps with a dnf
command. This is a great improvement for maintainability and clarity.
🔍 General Feedback
- The change is well-implemented and makes the script much easier to understand.
- I've left one minor suggestion to sort the packages for even better readability.
Overall, this is a solid improvement.
texlive-txfonts \ | ||
texlive-ulem \ | ||
texlive-upquote \ | ||
texlive-utopia \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟢 For better readability and easier maintenance, consider sorting the packages alphabetically.
There is a problem with the Gemini CLI PR review. Please check the action logs for details. |
well, first attempt not good, konflux is not subscribed
|
…sh` for ensuring up-to-date subscriptions
/build-konflux |
|
…r` repo and remove `subscription-manager refresh`
/build-konflux |
|
|
…t out unused repo enabling in `install_pdf_deps.sh`
/build-konflux |
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
No description provided.