-
Notifications
You must be signed in to change notification settings - Fork 20
[rhds] RHAIENG-304, RHAIENG-784: switch from Pipfile.lock
to pylock.toml
for package management across all relevant Dockerfiles
#1508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||
---|---|---|---|---|---|---|---|---|
|
@@ -159,13 +159,13 @@ ARG TENSORFLOW_SOURCE_CODE=jupyter/rocm/tensorflow/ubi9-python-3.12 | |||||||
|
||||||||
WORKDIR /opt/app-root/bin | ||||||||
|
||||||||
COPY ${TENSORFLOW_SOURCE_CODE}/requirements.txt ./ | ||||||||
COPY ${TENSORFLOW_SOURCE_CODE}/pylock.toml ./ | ||||||||
|
||||||||
RUN echo "Installing softwares and packages" && \ | ||||||||
# This may have to download and compile some dependencies, and as we don't lock requirements from `build-system.requires`, | ||||||||
# we often don't know the correct hashes and `--require-hashes` would therefore fail on non amd64, where building is common. | ||||||||
Comment on lines
165
to
166
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟢 This comment refers to
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Already tracked for subsequent fixing in |
||||||||
# Not using --build-constraints=./requirements.txt because error: Unnamed requirements are not allowed as constraints (found: `https://repo.radeon.com/rocm/manylinux/rocm-rel-6.4/ | ||||||||
uv pip install --strict --no-deps --no-cache --no-config --no-progress --verify-hashes --compile-bytecode --index-strategy=unsafe-best-match --requirements=./requirements.txt && \ | ||||||||
uv pip install --strict --no-deps --no-cache --no-config --no-progress --verify-hashes --compile-bytecode --index-strategy=unsafe-best-match --requirements=./pylock.toml && \ | ||||||||
# setup path for runtime configuration | ||||||||
mkdir /opt/app-root/runtimes && \ | ||||||||
# Remove default Elyra runtime-images \ | ||||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟢 For consistency, the comment should refer to
pylock.toml
instead ofrequirements.txt
, as that is the file being used for installation.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already tracked for subsequent fixing in