Skip to content

Conversation

atheo89
Copy link
Member

@atheo89 atheo89 commented Aug 28, 2025

Add konflux Dockerfiles for llmCompressor image this will be introduced on rhoai2.25

related to: https://issues.redhat.com/browse/RHAIENG-332

@openshift-ci openshift-ci bot requested review from daniellutz and dibryant August 28, 2025 15:33
Copy link

openshift-ci bot commented Aug 28, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jstourac for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@atheo89 atheo89 requested review from riprasad and jiridanek and removed request for daniellutz and dibryant August 28, 2025 15:33
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📋 Review Summary

This PR introduces two new Dockerfiles for the llmCompressor image with Konflux support. The Dockerfiles are well-structured and follow a multi-stage build pattern, which is great for keeping the final images small.

🔍 General Feedback

  • Redundancy: The two new Dockerfiles, jupyter/pytorch+llmcompressor/ubi9-python-3.12/Dockerfile.konflux.cuda and runtimes/pytorch+llmcompressor/ubi9-python-3.12/Dockerfile.konflux.cuda, are very similar. To improve maintainability and reduce code duplication, consider creating a common base image that both Dockerfiles can build upon. This would centralize the common setup steps and make future updates easier.
  • Hardcoded Versions: Several package versions are hardcoded in the Dockerfiles. Using build arguments (ARG) for these versions would make the images more flexible and easier to maintain.
  • Security: It's recommended to verify the checksums of downloaded artifacts to ensure their integrity.

Overall, the changes look good, but addressing the feedback above would improve the quality and maintainability of the Dockerfiles.

@atheo89
Copy link
Member Author

atheo89 commented Aug 28, 2025

Hey @riprasad this PR introduce the llmcompressor image for the upcoming release could you please take a look once you have the chance? There is also on the DevOps side this jira: https://issues.redhat.com/browse/RHOAIENG-32230 that tracks the tekton pipelines for the builds, I linked it here for your reference. Please let us know if anything else is needed.

@atheo89 atheo89 changed the title Add konflux Dockerfiles for llmCompressor image Add konflux Dockerfiles for LLMCompressor image Aug 28, 2025
@jiridanek
Copy link
Member

/lgtm

Copy link

openshift-ci bot commented Aug 28, 2025

@atheo89: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images 8e6c5b8 link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@atheo89 atheo89 merged commit c624fcd into red-hat-data-services:main Aug 29, 2025
16 of 22 checks passed
@jiridanek jiridanek added this to the rhoai-2.25 milestone Aug 29, 2025
@atheo89
Copy link
Member Author

atheo89 commented Aug 29, 2025

Incorporation to Operator: opendatahub-io/opendatahub-operator#2372

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants