-
Notifications
You must be signed in to change notification settings - Fork 22
Try using triton from pytorch for arm #1613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/build-konflux |
It's a dependency of torch, so it would seem that the same qualification should apply.
@grdryn: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Thank y @grdryn for this implementation, lets run the pipeline and see how it will goes. |
/kfbuild odh-workbench-jupyter-trustyai-cpu-py312 |
/build-konflux odh-workbench-jupyter-trustyai-cpu-py312 |
/hold I think this PR shouldn't be merged (although it's useful to run the job against, which previously successfully passed for Arm) @atheo89 Could you instead please take a look at opendatahub-io#2558 which should then get synced down to here (I think?), and #1614 for the 2.25 branch? |
Right, these changes will be sync from odh:main, i will run the builds on 2.25 |
Description
again
How Has This Been Tested?
Self checklist (all need to be checked):
make test
(gmake
on macOS) before asking for reviewDockerfile.konflux
files should be done inodh/notebooks
and automatically synced torhds/notebooks
. For Konflux-specific changes, modifyDockerfile.konflux
files directly inrhds/notebooks
as these require special attention in the downstream repository and flow to the upcoming RHOAI release.Merge criteria: