Skip to content

Conversation

grdryn
Copy link

@grdryn grdryn commented Oct 7, 2025

Description

again

How Has This Been Tested?

Self checklist (all need to be checked):

  • Ensure that you have run make test (gmake on macOS) before asking for review
  • Changes to everything except Dockerfile.konflux files should be done in odh/notebooks and automatically synced to rhds/notebooks. For Konflux-specific changes, modify Dockerfile.konflux files directly in rhds/notebooks as these require special attention in the downstream repository and flow to the upcoming RHOAI release.

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci openshift-ci bot requested review from atheo89 and jiridanek October 7, 2025 00:11
Copy link

openshift-ci bot commented Oct 7, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign paulovmr for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@grdryn
Copy link
Author

grdryn commented Oct 7, 2025

/build-konflux

It's a dependency of torch, so it would seem that the same
qualification should apply.
Copy link

openshift-ci bot commented Oct 7, 2025

@grdryn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images c8fd964 link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@atheo89
Copy link
Member

atheo89 commented Oct 7, 2025

Thank y @grdryn for this implementation, lets run the pipeline and see how it will goes.
/lgtm
/kfbuild odh-workbench-jupyter-trustyai-cpu-py312

@atheo89
Copy link
Member

atheo89 commented Oct 7, 2025

/kfbuild odh-workbench-jupyter-trustyai-cpu-py312

@atheo89
Copy link
Member

atheo89 commented Oct 7, 2025

/build-konflux odh-workbench-jupyter-trustyai-cpu-py312

@grdryn
Copy link
Author

grdryn commented Oct 7, 2025

/hold

I think this PR shouldn't be merged (although it's useful to run the job against, which previously successfully passed for Arm)

@atheo89 Could you instead please take a look at opendatahub-io#2558 which should then get synced down to here (I think?), and #1614 for the 2.25 branch?

@atheo89
Copy link
Member

atheo89 commented Oct 7, 2025

/hold

I think this PR shouldn't be merged (although it's useful to run the job against, which previously successfully passed for Arm)

@atheo89 Could you instead please take a look at opendatahub-io#2558 which should then get synced down to here (I think?), and #1614 for the 2.25 branch?

Right, these changes will be sync from odh:main, i will run the builds on 2.25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants