Skip to content

Conversation

daniellutz
Copy link

The 2025b upgrade should also update PyTorch ROCm package to use ROCm 6.3 instead of ROCm 6.2.4.

How Has This Been Tested?

make test

Self checklist (all need to be checked):

  • Ensure that you have run make test (gmake on macOS) before asking for review
  • Changes to everything except Dockerfile.konflux files should be done in odh/notebooks and automatically synced to rhds/notebooks. For Konflux-specific changes, modify Dockerfile.konflux files directly in rhds/notebooks as these require special attention in the downstream repository and flow to the upcoming RHOAI release.

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link
Member

@atheo89 atheo89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@atheo89
Copy link
Member

atheo89 commented Oct 8, 2025

/cherrypick rhoai-2.25

@openshift-cherrypick-robot

@atheo89: once the present PR merges, I will cherry-pick it on top of rhoai-2.25 in a new PR and assign it to you.

In response to this:

/cherrypick rhoai-2.25

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot removed the lgtm label Oct 8, 2025
Copy link

openshift-ci bot commented Oct 8, 2025

@daniellutz: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images da3d71c link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Member

@jiridanek jiridanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on updating also the runtime images

Copy link

openshift-ci bot commented Oct 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atheo89, jiridanek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@daniellutz daniellutz merged commit a00d9f0 into red-hat-data-services:main Oct 8, 2025
15 of 22 checks passed
@daniellutz daniellutz deleted the downstream-pytorch-rocm-63 branch October 8, 2025 15:37
@openshift-cherrypick-robot

@atheo89: new pull request created: #1622

In response to this:

/cherrypick rhoai-2.25

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants