[DO NOT MERGE] experiment the new wheels index #1631
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/konflux-builds |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
📋 Review Summary
This PR experiments with a new wheels index. The changes are well-contained and the purpose is clearly stated in the PR title. I've left one minor comment about removing a developer note from the pyproject.toml file.
🔍 General Feedback
- The changes in the
Makefileto limit the build scope for experimentation are reasonable. - The
pylock.tomlfile has been updated correctly to reflect the changes inpyproject.tomland the new package index. - The use of a private index is clearly configured in the
pyproject.tomlfile.
Overall, this PR is a good example of how to experiment with new features in a controlled way.
| "odh-jupyter-trash-cleanup==0.1.1", # This should be added on the aipcc index as well | ||
|
|
||
| "jupyterlab==4.4.7", | ||
| "jupyterlab==4.4.9", # This had to be upgraded from 4.4.7 to 4.4.9 |
There was a problem hiding this comment.
🟢 This comment seems to be a note for the developer and can be removed.
|
/build-konflux |
|
/build-konflux |
|
@atheo89: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/build-konflux |
1 participant
Description
How Has This Been Tested?
Self checklist (all need to be checked):
make test(gmakeon macOS) before asking for reviewDockerfile.konfluxfiles should be done inodh/notebooksand automatically synced torhds/notebooks. For Konflux-specific changes, modifyDockerfile.konfluxfiles directly inrhds/notebooksas these require special attention in the downstream repository and flow to the upcoming RHOAI release.Merge criteria: