RHAIENG-3083: Create and shift the N and N-1#1892
RHAIENG-3083: Create and shift the N and N-1#1892dibryant wants to merge 3 commits intored-hat-data-services:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| from: | ||
| kind: DockerImage | ||
| name: odh-workbench-jupyter-tensorflow-cuda-py311-ubi9-n-8_PLACEHOLDER | ||
| name: "1.2" |
There was a problem hiding this comment.
The 1.2 tag here caught my attention because I noticed it again in line 323. Please remove this block and update the tag sequence to follow n, n-1, n-2, …, n-x here: [link] because n-1 placeholder appears twice (https://github.com/dibryant/notebooks/blob/c40379fbab6b1de1178807986238b8ad6274fff7/manifests/base/jupyter-tensorflow-notebook-imagestream.yaml#L136C69-L136C114)
.
(Note: this comment may also apply to the other imagestreams.)
c40379f to
8e20c80
Compare
8e20c80 to
bf42744
Compare
|
@dibryant: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Fixes for https://issues.redhat.com/browse/RHAIENG-3083
Description
Shift N-1-N7
How Has This Been Tested?
Self checklist (all need to be checked):
make test(gmakeon macOS) before asking for reviewDockerfile.konfluxfiles should be done inodh/notebooksand automatically synced torhds/notebooks. For Konflux-specific changes, modifyDockerfile.konfluxfiles directly inrhds/notebooksas these require special attention in the downstream repository and flow to the upcoming RHOAI release.Merge criteria: