Skip to content

RHAIENG-3083: Create and shift the N and N-1#1892

Open
dibryant wants to merge 3 commits intored-hat-data-services:mainfrom
dibryant:rhaieng3083
Open

RHAIENG-3083: Create and shift the N and N-1#1892
dibryant wants to merge 3 commits intored-hat-data-services:mainfrom
dibryant:rhaieng3083

Conversation

@dibryant
Copy link

Fixes for https://issues.redhat.com/browse/RHAIENG-3083

Description

Shift N-1-N7

How Has This Been Tested?

Self checklist (all need to be checked):

  • Ensure that you have run make test (gmake on macOS) before asking for review
  • Changes to everything except Dockerfile.konflux files should be done in odh/notebooks and automatically synced to rhds/notebooks. For Konflux-specific changes, modify Dockerfile.konflux files directly in rhds/notebooks as these require special attention in the downstream repository and flow to the upcoming RHOAI release.

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci openshift-ci bot requested review from atheo89 and ysok February 11, 2026 16:41
@openshift-ci
Copy link

openshift-ci bot commented Feb 11, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign daniellutz for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

from:
kind: DockerImage
name: odh-workbench-jupyter-tensorflow-cuda-py311-ubi9-n-8_PLACEHOLDER
name: "1.2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 1.2 tag here caught my attention because I noticed it again in line 323. Please remove this block and update the tag sequence to follow n, n-1, n-2, …, n-x here: [link] because n-1 placeholder appears twice (https://github.com/dibryant/notebooks/blob/c40379fbab6b1de1178807986238b8ad6274fff7/manifests/base/jupyter-tensorflow-notebook-imagestream.yaml#L136C69-L136C114)
.

(Note: this comment may also apply to the other imagestreams.)

@openshift-ci
Copy link

openshift-ci bot commented Feb 12, 2026

@dibryant: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images 896eb1f link true /test images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants