-
Notifications
You must be signed in to change notification settings - Fork 20
RHOAIENG-21668: chore(gha): run GitHub Actions CI for our RHEL-based workbenches #514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
After andy's unchaining of build gets into RHDS, I'll update the pr; for now it builds, runs some tests, but deploy9 fails https://github.com/jiridanek/notebooks/actions/runs/13636395252/job/38116170177 |
The main magic there is
and then
|
Hey @jiridanek in case that we include that pr on main could you fix the commits before? |
I'll be taking a look later today as i do the necessary rebase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ℹ️
will (likely/possibly) be "obvious" when it comes time to do the rebase...
but a lot of the "leaf" logic in the gen matrix script can be discarded - and instead the all-images
Makefile
target simply needs updated to add the targets we want to build..
all of it can be discarded and the gha "matrix" can build everything now there is no reason to build pushes and prs differently, the way it used to be the case |
061252d
to
5f146bd
Compare
c4b5211
to
090a470
Compare
e4c8380
to
d471320
Compare
Here's how this is supposed to work. On a subscribed machine, podman mounts the secrets directory into the container as a volume. ``` $ cat /usr/share/containers/mounts.conf /usr/share/rhel/secrets:/run/secrets ``` Furthermore, there may be ``/run/secrets/etc-pki-entitlement` and ``/run/secrets/rhsm`. The approach that actually worked for me is https://access.redhat.com/solutions/5558771 First, `subscription-manager` detects a container and behaves differently there. So, run `subscription-manager` with `SMDEV_CONTAINER_OFF=1` to subscribe container as if it was a physical machine. Then, look into `/etc/pki/entitlement` for certificates as suggested in https://grep.be/blog//en/work/The_future_of_the_eID_on_RHEL/ ``` podman run --platform=linux/amd64 -v/Users/jdanek/IdeaProjects/notebooks/ci/secrets/run/secrets:/mnt --rm -it registry.access.redhat.com/ubi9/ubi 1 subscription-manager register --username 3 cp -R /etc/pki/entitlement /mnt/etc-pki-entitlement 5 cp -R /etc/rhsm /mnt/rhsm 7 cp /etc/yum.repos.d/redhat.repo /mnt/redhat.repo ``` Finally, copy out and store the certificates as CI secrets for reuse in jobs.
df27bf5
to
457aecb
Compare
…nager credentials using `git-crypt` ``` git-crypt init git-crypt export-key git-crypt-key base64 git-crypt-key | gh secret set GIT_CRYPT_KEY --repo red-hat-data-services/notebook ``` Implement the security check to only allow builds for project contributors
b959192
to
9803a77
Compare
…st_trigger workflow
/lgtm |
/approve but that won't work since we don't have tide any more? |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jiridanek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
https://issues.redhat.com/browse/RHOAIENG-21668
previously discussed on slack
depends on @andyatmiami 's rstudio work in
How tested
Notes
There does not seem a way to prevent the build to invalidate the stored secret by mistake, and then I get
docs
subscription-manager usage in containers
UBI and RHEL subscription considerations discussions