Skip to content

Add sparkoperator support in DSC configuration and tests#2839

Open
shruthis4 wants to merge 3 commits intored-hat-data-services:masterfrom
shruthis4:ods-ci_tests
Open

Add sparkoperator support in DSC configuration and tests#2839
shruthis4 wants to merge 3 commits intored-hat-data-services:masterfrom
shruthis4:ods-ci_tests

Conversation

@shruthis4
Copy link

@shruthis4 shruthis4 commented Jan 21, 2026

  • Updated dsc_template.yml to include sparkoperator management state.
  • Modified oc_install.robot to check for sparkoperator component status during installation.
  • Enhanced 0113__dsc_components.robot with validation for sparkoperator's default and managed states, ensuring proper resource handling.

@openshift-ci
Copy link

openshift-ci bot commented Jan 21, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 21, 2026
View reviewed changes
@openshift-ci
Copy link

openshift-ci bot commented Jan 22, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shruthis4

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 22, 2026
View reviewed changes
.../0100__platform/0101__deploy/0104__operators/0104__rhods_operator/0113__dsc_components.robot
${SAVED_MANAGEMENT_STATES.FEASTOPERATOR}= Get DSC Component State ${DSC_NAME} feastoperator ${OPERATOR_NS}
${SAVED_MANAGEMENT_STATES.LLAMASTACKOPERATOR}= Get DSC Component State ${DSC_NAME} llamastackoperator ${OPERATOR_NS}
${SAVED_MANAGEMENT_STATES.MLFLOWOPERATOR}= Get DSC Component State ${DSC_NAME} mlflowoperator ${OPERATOR_NS}
${SAVED_MANAGEMENT_STATES.SPARKOPERATOR}= Get DSC Component State ${DSC_NAME} sparkoperator

Check notice

Code scanning / Robocop

Variable '{{ name }}' is assigned but not used Note test

Variable '${SAVED_MANAGEMENT_STATES.SPARKOPERATOR}' is assigned but not used
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 22, 2026
View reviewed changes
.../0100__platform/0101__deploy/0104__operators/0104__rhods_operator/0113__dsc_components.robot
... ${SPARKOPERATOR_DEPLOYMENT_NAME} ${SPARKOPERATOR_LABEL_SELECTOR}
... ${SAVED_MANAGEMENT_STATES.SPARKOPERATOR}

Validate Spark Removed State

Check warning

Code scanning / Robocop

Test case '{{ test_name }}' is too long ({{ test_length }}/{{ allowed_length }}) Warning test

Test case 'Validate Spark Removed State' is too long (21/20)
@shruthis4 shruthis4 requested a review from asanzgom January 22, 2026 18:37
@shruthis4
Add sparkoperator support in DSC configuration and tests
75ab90f 
- Updated dsc_template.yml to include sparkoperator management state.
- Modified oc_install.robot to check for sparkoperator component status during installation.
- Enhanced 0113__dsc_components.robot with validation for sparkoperator's default and managed states, ensuring proper resource handling.
@shruthis4
Refactor Sparkoperator validation tests in 0113__dsc_components.robot
c7f6626
@shruthis4
Shorten the testcase names as per robocop expectations
db0e3d3
@shruthis4 shruthis4 marked this pull request as ready for review February 10, 2026 19:17
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 10, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@shruthis4
Copy link
Author

shruthis4 commented Feb 11, 2026

@asanzgom: Is there a way to qualify these tests before submission?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asanzgom asanzgom Awaiting requested review from asanzgom

@Vedant-Deshpande Vedant-Deshpande Awaiting requested review from Vedant-Deshpande

@alimaredia alimaredia Awaiting requested review from alimaredia

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@shruthis4