Skip to content

DFBUGS-5556: [release-4.20] connection: refactor state management and idle timer sync#390

Open
black-dragon74 wants to merge 7 commits intored-hat-storage:release-4.20from
black-dragon74:DFBUGS-5556
Open

DFBUGS-5556: [release-4.20] connection: refactor state management and idle timer sync#390
black-dragon74 wants to merge 7 commits intored-hat-storage:release-4.20from
black-dragon74:DFBUGS-5556

Conversation

@black-dragon74
Copy link
Member

@black-dragon74 black-dragon74 commented Feb 13, 2026

This patch does the following:

  • Removes gRPC dial option to automatically close idle connections.
  • The connections are still closed after 30mins of inactivity (gRPC default)
  • Removes manual work around the same.
  • Adds unit tests for connection

Upstream PR:

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference jira/invalid-bug labels Feb 13, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 13, 2026

@black-dragon74: This pull request references [Jira Issue DFBUGS-5556](https://issues.redhat.com//browse/DFBUGS-5556), which is invalid:

  • expected the bug to target the "odf-4.20.6" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

This patch does the following:

  • Removes gRPC dial option to automatically close idle connections.
  • The connections are still closed after 30mins of inactivity (gRPC default)
  • Removes manual work around the same.
  • Adds unit tests for connection

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link

openshift-ci bot commented Feb 13, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: black-dragon74

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@black-dragon74 black-dragon74 changed the title DFBUGS-5556: [release-4.21] connection: refactor state management and idle timer sync DFBUGS-5556: [release-4.20] connection: refactor state management and idle timer sync Feb 13, 2026
@black-dragon74
Copy link
Member Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting and removed jira/invalid-bug labels Feb 13, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 13, 2026

@black-dragon74: This pull request references [Jira Issue DFBUGS-5556](https://issues.redhat.com//browse/DFBUGS-5556), which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (odf-4.20.6) matches configured target version for branch (odf-4.20.6)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (posharma@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Signed-off-by: Niraj Yadav <niryadav@redhat.com>
(cherry picked from commit 949d08e)
Signed-off-by: Niraj Yadav <niryadav@redhat.com>
(cherry picked from commit afa51ed)
Signed-off-by: Niraj Yadav <niryadav@redhat.com>
(cherry picked from commit 3fde4bf)
Signed-off-by: Niraj Yadav <niryadav@redhat.com>
(cherry picked from commit ea72d5c)
This patch does the following:
- Uses gRPC default idle timeout to close connection after 30mins.
- Removes manual work around the same.

Signed-off-by: Niraj Yadav <niryadav@redhat.com>
(cherry picked from commit 6680b85)
Signed-off-by: Niraj Yadav <niryadav@redhat.com>
(cherry picked from commit c9d6212)
@black-dragon74 black-dragon74 force-pushed the DFBUGS-5556 branch 2 times, most recently from 559d9d1 to bb11091 Compare February 16, 2026 08:05
Signed-off-by: Niraj Yadav <niryadav@redhat.com>
@openshift-ci-robot openshift-ci-robot added jira/invalid-bug and removed jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting labels Feb 16, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 16, 2026

@black-dragon74: This pull request references [Jira Issue DFBUGS-5556](https://issues.redhat.com//browse/DFBUGS-5556), which is invalid:

  • expected the bug to target the "odf-4.20.6" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

This patch does the following:

  • Removes gRPC dial option to automatically close idle connections.
  • The connections are still closed after 30mins of inactivity (gRPC default)
  • Removes manual work around the same.
  • Adds unit tests for connection

Upstream PR:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@nixpanic
Copy link
Member

nixpanic commented Mar 3, 2026

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 3, 2026

@nixpanic: This pull request references [Jira Issue DFBUGS-5556](https://issues.redhat.com//browse/DFBUGS-5556), which is invalid:

  • expected the bug to target the "odf-4.20.6" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved jira/invalid-bug jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants