class and template for client profile#11759
Merged
dahorak merged 3 commits intored-hat-storage:master-converged-modefrom Apr 7, 2025
Merged
class and template for client profile#11759dahorak merged 3 commits intored-hat-storage:master-converged-modefrom
dahorak merged 3 commits intored-hat-storage:master-converged-modefrom
Conversation
DanielOsypenko
requested review from
a team,
amr1ta,
dahorak,
fbalak,
jilju,
suchita-g and
yitzhak12
DanielOsypenko
force-pushed
the
client-profile-class
branch
from
982c6b1 to
ea07e10
Compare
DanielOsypenko
force-pushed
the
master-converged-mode
branch
3 times, most recently
from
ff8a807 to
5b2b86c
Compare
ebondare
approved these changes
Apr 4, 2025
DanielOsypenko
force-pushed
the
client-profile-class
branch
from
ea07e10 to
65afbfa
Compare
dahorak
approved these changes
Apr 7, 2025
Contributor
dahorak
left a comment
dahorak
left a comment
There was a problem hiding this comment.
Just two questions/comments, otherwise LGTM.
suchita-g
approved these changes
Apr 7, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dahorak, DanielOsypenko, ebondare, suchita-g The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
New changes are detected. LGTM label has been removed. |
Signed-off-by: Daniel Osypenko <dosypenk@redhat.com>
review fix Co-authored-by: dahorak <dahorak@redhat.com>
Signed-off-by: Daniel Osypenko <dosypenk@redhat.com>
DanielOsypenko
force-pushed
the
client-profile-class
branch
from
c4dcb0b to
cdbbfe4
Compare
dahorak
merged commit ac86877
into
red-hat-storage:master-converged-mode
5 of 7 checks passed
DanielOsypenko
added a commit
to DanielOsypenko/ocs-ci
that referenced
this pull request
Apr 7, 2025
* class and template for clientprofile Signed-off-by: Daniel Osypenko <dosypenk@redhat.com>
petr-balogh
pushed a commit
that referenced
this pull request
Apr 8, 2025
* class and template for clientprofile Signed-off-by: Daniel Osypenko <dosypenk@redhat.com>
paraggit
pushed a commit
that referenced
this pull request
Apr 15, 2025
* class and template for clientprofile Signed-off-by: Daniel Osypenko <dosypenk@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New python class and utilities introduced in order to cover product change: ceph/ceph-csi-operator#165