Syncing latest changes from main for ocs-client-operator #491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ran below: go get [email protected] [email protected] cd api/ && go get [email protected] [email protected] && cd - make godeps-update Signed-off-by: Leela Venkaiah G <[email protected]>
godeps: update go version to 1.24.6
consumer id on storageclient status is only populated after a successful onboard and there is no point in halting the deletion stuck on finalizer. Signed-off-by: Leela Venkaiah G <[email protected]>
controllers: allow deleting a not onboarded client
leelavg
approved these changes
Oct 28, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: df-build-team, leelavg The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR containing the latest commits from main branch