controllers: add and remove finalizer for all child resources #515
+211
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leelavg The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Author
|
Depends on ocs-operator/pull/3686 |
when a resource is deleted it gets recreated due to a cached copied and there is no other way for our existing machinery to distinguish the resource between recreation and user intention, we use finalizer to catch the intention and clean them up. this is in unison with hub not distributing resources marked for deletion. Signed-off-by: Leela Venkaiah G <lgangava@ibm.com>
Signed-off-by: Leela Venkaiah G <lgangava@ibm.com>
Contributor
Author
|
Tested:
Note: Working on regression in deletion. |
Contributor
Author
|
/hold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when a resource is deleted it gets recreated due to a cached copied and there is no other way for our existing machinery to distinguish the resource between recreation and user intention, we use finalizer to catch the intention and clean them up.
this is in unison with hub not distributing resources marked for deletion.