-
Notifications
You must be signed in to change notification settings - Fork 188
util: add kernel version checks libraries #3344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iamniting The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ec7fa87 to
f22e89f
Compare
|
/test ocs-operator-bundle-e2e-aws |
nixpanic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A unit test that shows how these functions work together would be very welcome.
6254c8e to
670a02b
Compare
nixpanic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This version checking is pretty much RHEL specific, this is fine but could be noted somewhere.
Added one question, otherwise it looks good to me, thanks.
As far as we are concerned with rhel and coreos. As far as I remember, we discussed that it is going to be the same for both. Pls correct me if I am wrong. |
That is correct. Red Hat CoreOS is based on RHEL, it has the same kernel builds and versioning. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better be explicit in the filename that we are dealing w/ kernel version as we already have a version folder at the root and during imports it helps to distinguish?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
| @@ -0,0 +1,104 @@ | |||
| package util | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add a sample unit test on how you intend that one should use these util funcs? isn't the intention just to export a single func whether I can rotate the ceph key or not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
These funcs allow user to check the kernel support on ocp cluster Signed-off-by: Nitin Goyal <nigoyal@redhat.com>
|
@iamniting @leelavg ocs-client-operator will also require this functionality to send the kernel version of nodes to the provider, |
You mean under |
As per discussion with Ohad, this move should not be done. |
These funcs allow user to check the kernel support on ocp cluster
Signed-off-by: Nitin Goyal nigoyal@redhat.com
https://issues.redhat.com/browse/RHSTOR-7293