Skip to content

Conversation

@iamniting
Copy link
Member

@iamniting iamniting commented Jul 2, 2025

These funcs allow user to check the kernel support on ocp cluster

Signed-off-by: Nitin Goyal nigoyal@redhat.com

https://issues.redhat.com/browse/RHSTOR-7293

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 2, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamniting

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 2, 2025
@iamniting iamniting force-pushed the version branch 2 times, most recently from ec7fa87 to f22e89f Compare July 2, 2025 05:33
@iamniting
Copy link
Member Author

/test ocs-operator-bundle-e2e-aws

Copy link
Member

@nixpanic nixpanic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A unit test that shows how these functions work together would be very welcome.

@iamniting iamniting force-pushed the version branch 3 times, most recently from 6254c8e to 670a02b Compare July 7, 2025 06:17
Copy link
Member

@nixpanic nixpanic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version checking is pretty much RHEL specific, this is fine but could be noted somewhere.

Added one question, otherwise it looks good to me, thanks.

@iamniting
Copy link
Member Author

This version checking is pretty much RHEL specific, this is fine but could be noted somewhere.

Added one question, otherwise it looks good to me, thanks.

As far as we are concerned with rhel and coreos. As far as I remember, we discussed that it is going to be the same for both. Pls correct me if I am wrong.

@nixpanic
Copy link
Member

nixpanic commented Jul 7, 2025

As far as we are concerned with rhel and coreos. As far as I remember, we discussed that it is going to be the same for both. Pls correct me if I am wrong.

That is correct. Red Hat CoreOS is based on RHEL, it has the same kernel builds and versioning.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better be explicit in the filename that we are dealing w/ kernel version as we already have a version folder at the root and during imports it helps to distinguish?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@@ -0,0 +1,104 @@
package util
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a sample unit test on how you intend that one should use these util funcs? isn't the intention just to export a single func whether I can rotate the ceph key or not?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

These funcs allow user to check the kernel support on ocp cluster

Signed-off-by: Nitin Goyal <nigoyal@redhat.com>
@rohan47
Copy link
Contributor

rohan47 commented Jul 29, 2025

@iamniting @leelavg ocs-client-operator will also require this functionality to send the kernel version of nodes to the provider,
will it make sense to move this changes to provider api?
else this will have to be copied to ocs-client-operator as well

@iamniting
Copy link
Member Author

@iamniting @leelavg ocs-client-operator will also require this functionality to send the kernel version of nodes to the provider, will it make sense to move this changes to provider api? else this will have to be copied to ocs-client-operator as well

You mean under services/provider/api as a new directory

@rohan47
Copy link
Contributor

rohan47 commented Jul 29, 2025

@iamniting @leelavg ocs-client-operator will also require this functionality to send the kernel version of nodes to the provider, will it make sense to move this changes to provider api? else this will have to be copied to ocs-client-operator as well

You mean under services/provider/api as a new directory

As per discussion with Ohad, this move should not be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants