Skip to content

Fix HealthOverview's Silence modal duration dropdown#2517

Open
aruniiird wants to merge 1 commit intored-hat-storage:masterfrom
aruniiird:fix-healthoverview-silence-modal-duration-dropdown-dfbugs-5375
Open

Fix HealthOverview's Silence modal duration dropdown#2517
aruniiird wants to merge 1 commit intored-hat-storage:masterfrom
aruniiird:fix-healthoverview-silence-modal-duration-dropdown-dfbugs-5375

Conversation

@aruniiird
Copy link
Contributor

Duration dropdown was giving a vertical scroll bar that renders inside the modal body, instead of poping out and show all the options.

The change should render the dropdown menu as a child of 'document.body' instead of inside the modal. The dropdown will now "pop out" of the modal and be fully visible.

Duration dropdown was giving a vertical scroll bar that
renders inside the modal body, instead of poping out and
show all the options.

The change should render the dropdown menu as a child of
'document.body' instead of inside the modal. The dropdown
will now "pop out" of the modal and be fully visible.

Signed-off-by: Arun Kumar Mohan <amohan@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 27, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aruniiird
Once this PR has been reviewed and has the lgtm label, please assign sanjalkatiyar for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 27, 2026

@aruniiird: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/odf-console-e2e-aws 9fcf3a7 link true /test odf-console-e2e-aws

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant