added forceful deployment option by gourhari1 · Pull Request #2602 · red-hat-storage/odf-console

gourhari1 · 2026-02-26T09:29:27Z

issues: https://issues.redhat.com/browse/RHSTOR-8584

openshift-ci · 2026-02-26T09:29:37Z

Hi @gourhari1. Thanks for your PR.

I'm waiting for a red-hat-storage member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

gourhari1 · 2026-02-26T09:33:41Z

locales/en/plugin__odf-console.json

...storage-system/create-storage-system-steps/advanced-settings-step/advanced-settings-step.tsx

packages/odf/components/create-storage-system/footer.tsx

SanjalKatiyar · 2026-02-26T11:40:53Z

packages/odf/components/utils/common.ts

+  if (enableForcefulDeployment) {
+    requestData.spec.forcefulDeployment = {
+      enabled: enableForcefulDeployment,
+    };
+  }


can plz u paste some reference where it says that this is the correct field that we need to add for this use case ??

I have recitified it with required change after discussing with backend owner.

SanjalKatiyar · 2026-02-26T11:43:35Z

/ok-to-test

openshift-ci · 2026-03-02T07:26:57Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gourhari1
Once this PR has been reviewed and has the lgtm label, please ask for approval from sanjalkatiyar. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

SanjalKatiyar · 2026-03-03T07:04:37Z

locales/en/plugin__odf-console.json

  "Out of {{capacity}}": "Out of {{capacity}}",
  "Over the past {{daysUp}} ": "Over the past {{daysUp}} ",
  "Overall image health": "Overall image health",
+  "Override and completely wipe any data on disks used to create this storage system": "Override and completely wipe any data on disks used to create this storage system",


Suggested change

"Override and completely wipe any data on disks used to create this storage system": "Override and completely wipe any data on disks used to create this storage system",

"Override and completely wipe any data on disks used to create this storage cluster": "Override and completely wipe any data on disks used to create this storage system",

SanjalKatiyar · 2026-03-03T07:10:40Z

packages/odf/components/utils/common.ts

+  if (enableForcefulDeployment) {
+    requestData.spec.managedResources.cephCluster.cleanupPolicy = {
+      wipeDevicesFromOtherClusters: enableForcefulDeployment,
+    };
+  }


Is this tested ? didn't u get any error ?

requestData.spec.managedResources.cephCluster is undefined, u should have gotten error when accessing requestData.spec.managedResources.cephCluster.cleanupPolicy.

SanjalKatiyar · 2026-03-03T07:11:23Z

plz add the latest screenshot as well...

SanjalKatiyar · 2026-03-03T07:14:46Z

packages/odf/components/utils/common.ts

+  if (enableForcefulDeployment) {
+    requestData.spec.managedResources.cephCluster.cleanupPolicy = {
+      wipeDevicesFromOtherClusters: enableForcefulDeployment,
+    };
+  }


Suggested change

if (enableForcefulDeployment) {

requestData.spec.managedResources.cephCluster.cleanupPolicy = {

wipeDevicesFromOtherClusters: enableForcefulDeployment,

};

}

if (enableForcefulDeployment) {

requestData.spec.managedResources = {

...requestData.spec.managedResources,

cephCluster: { wipeDevicesFromOtherClusters: true },

},

};

SanjalKatiyar · 2026-03-03T07:18:08Z

packages/odf/components/utils/common.ts

    };
  }
+  // Add forceful deployment configuration if enabled
+  if (enableForcefulDeployment) {


nits:

Suggested change

if (enableForcefulDeployment) {

if (isNoProvisioner && enableForcefulDeployment) {

SanjalKatiyar · 2026-03-09T07:56:24Z

packages/odf/components/utils/common.ts

+  // Add forceful deployment configuration if enabled
+  if (isNoProvisioner && enableForcefulDeployment) {
+    requestData.spec.managedResources.cephCluster = {
+      ...requestData.spec.managedResources.cephCluster,


again, did u test this flow by creating a storage cluster ?

did u not get any error like cannot read property undefined while destruct ??

as mentioned earlier, requestData.spec.managedResources.cephCluster is undefined, right ?

#2602 (comment)

SanjalKatiyar · 2026-03-09T09:19:47Z

packages/odf/components/utils/common.ts

+    requestData.spec.managedResources.cephCluster = {
+      ...(requestData.spec.managedResources
+        .cephCluster as ManagedResourcesCephClusterKind),


Suggested change

requestData.spec.managedResources.cephCluster = {

...(requestData.spec.managedResources

.cephCluster as ManagedResourcesCephClusterKind),

requestData.spec.managedResources.cephCluster = {

...(requestData.spec.managedResources

.cephCluster || ({} as ManagedResourcesCephClusterKind)),

bipuladh · 2026-03-11T02:43:05Z

packages/odf/components/create-storage-system/footer.tsx

+  // The Next button is disabled when forceful deployment is enabled but confirmation text not equals confirm
+  const hasForcefulDeploymentButNoConfirmation =
+    enableForcefulDeployment &&
+    !(forcefulDeploymentConfirmation?.trim().toLowerCase() === 'confirm');


Please keep this as upper case validation as if user writes it lower case we might want to stop it since the placeholder is all caps.

openshift-ci bot added the needs-ok-to-test label Feb 26, 2026

SanjalKatiyar requested changes Feb 26, 2026

View reviewed changes

openshift-ci bot assigned SanjalKatiyar Feb 26, 2026

openshift-ci bot added ok-to-test and removed needs-ok-to-test labels Feb 26, 2026

gourhari1 force-pushed the RHSTOR-8584/Add-Forceful-deployment-option-in-the-storage-cluster-creation-UI branch from a4fd979 to 40f6dcd Compare March 2, 2026 07:26

gourhari1 force-pushed the RHSTOR-8584/Add-Forceful-deployment-option-in-the-storage-cluster-creation-UI branch 3 times, most recently from 10eb5c4 to e0901d7 Compare March 2, 2026 07:57

SanjalKatiyar reviewed Mar 3, 2026

View reviewed changes

gourhari1 force-pushed the RHSTOR-8584/Add-Forceful-deployment-option-in-the-storage-cluster-creation-UI branch from e0901d7 to be21c1b Compare March 3, 2026 12:22

SanjalKatiyar reviewed Mar 9, 2026

View reviewed changes

gourhari1 force-pushed the RHSTOR-8584/Add-Forceful-deployment-option-in-the-storage-cluster-creation-UI branch 2 times, most recently from 8610d33 to 88614f9 Compare March 9, 2026 08:56

SanjalKatiyar reviewed Mar 9, 2026

View reviewed changes

gourhari1 force-pushed the RHSTOR-8584/Add-Forceful-deployment-option-in-the-storage-cluster-creation-UI branch 2 times, most recently from 7a5305a to 1b4d48c Compare March 10, 2026 11:58

bipuladh reviewed Mar 11, 2026

View reviewed changes

added forceful deployment option

1846bd9

gourhari1 force-pushed the RHSTOR-8584/Add-Forceful-deployment-option-in-the-storage-cluster-creation-UI branch from 1b4d48c to 1846bd9 Compare March 11, 2026 04:41

	"Override and completely wipe any data on disks used to create this storage system": "Override and completely wipe any data on disks used to create this storage system",
	"Override and completely wipe any data on disks used to create this storage cluster": "Override and completely wipe any data on disks used to create this storage system",

	if (enableForcefulDeployment) {
	if (isNoProvisioner && enableForcefulDeployment) {

Conversation

gourhari1 commented Feb 26, 2026

Uh oh!

openshift-ci bot commented Feb 26, 2026

Uh oh!

gourhari1 commented Feb 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SanjalKatiyar commented Feb 26, 2026

Uh oh!

openshift-ci bot commented Mar 2, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SanjalKatiyar commented Mar 3, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

gourhari1 commented Feb 26, 2026 •

edited

Loading