Skip to content

webhook: mutate rook op csv if previeous csv had hostNetwork enabled #670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 1 commit into from
Oct 30, 2025
Merged

webhook: mutate rook op csv if previeous csv had hostNetwork enabled #670

openshift-merge-bot merged 1 commit into from
Oct 30, 2025

Conversation

@rohan47
Copy link
Contributor

@rohan47 rohan47 commented Aug 18, 2025 •
edited by iamniting
Loading

updated webhook to mutate csv if the previous csv had hostNetwork enabled for deployment in order to persist csv update from red-hat-storage/ocs-operator#3423

Bug: https://issues.redhat.com/browse/DFBUGS-3832

@rohan47 rohan47 mentioned this pull request Aug 18, 2025
Merged
iamniting
iamniting requested changes Aug 18, 2025
View reviewed changes
Copy link
Member

@iamniting iamniting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not write rook csv specific code, We should have a generic code which works for all csvs.

@rohan47
Copy link
Contributor Author

rohan47 commented Aug 19, 2025

We should not write rook csv specific code, We should have a generic code which works for all csvs.

Generic code will not work in this case as we need t update rook-ceph-operator deployment specifically,
if we want generic then the configmap needs to be updated

@rohan47
Copy link
Contributor Author

rohan47 commented Aug 19, 2025

We should not write rook csv specific code, We should have a generic code which works for all csvs.

Generic code will not work in this case as we need t update rook-ceph-operator deployment specifically, if we want generic then the configmap needs to be updated

Making changes as dicsussed

@rohan47 rohan47 force-pushed the rook_csv branch 6 times, most recently from 562d333 to 82e1766 Compare August 19, 2025 15:21
iamniting
iamniting approved these changes Aug 19, 2025
View reviewed changes
Copy link
Member

@iamniting iamniting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold for @nb-ohad review.

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. do-not-merge/hold approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 19, 2025
@iamniting
Copy link
Member

iamniting commented Aug 19, 2025

/cherry-pick release-4.20

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Aug 19, 2025

@iamniting: once the present PR merges, I will cherry-pick it on top of release-4.20 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 28, 2025
@rohan47 rohan47 force-pushed the rook_csv branch 2 times, most recently from 3782088 to 6d3db8d Compare August 28, 2025 14:16
iamniting
iamniting approved these changes Aug 28, 2025
View reviewed changes
Copy link
Member

@iamniting iamniting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm @nb-ohad Can you take a look

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 28, 2025
nb-ohad
nb-ohad requested changes Sep 2, 2025
View reviewed changes
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 2, 2025
iamniting
iamniting requested changes Sep 2, 2025
View reviewed changes
@openshift-ci openshift-ci bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2025
@rohan47 rohan47 force-pushed the rook_csv branch 5 times, most recently from d85786b to df9c3bd Compare September 4, 2025 13:36
iamniting
iamniting requested changes Sep 4, 2025
View reviewed changes
@ezio-auditore
Copy link

ezio-auditore commented Oct 13, 2025

/test odf-operator-e2e-aws

@iamniting
Copy link
Member

iamniting commented Oct 28, 2025

/unhold

@rohan47 rohan47 force-pushed the rook_csv branch 4 times, most recently from 0e8226c to 4980371 Compare October 30, 2025 05:14
iamniting
iamniting requested changes Oct 30, 2025
View reviewed changes
Copy link
Member

@iamniting iamniting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also change the commit msg to include the DNSPolicy?

@rohan47
controllers: ensure CSV inherits network config from previous deployment
f00bc28 
The webhook now mutates the ClusterServiceVersion (CSV) to set
`hostNetwork` and `dnsPolicy` on deployments from the replaced CSV.
This ensures continuity of networking configuration across
operator upgrades and avoids potential deployment issues caused
by missing `hostNetwork` and `dnsPolicy` in the new CSV.

Signed-off-by: Rohan Gupta <rohgupta@redhat.com>
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamniting, rohan47

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 2209d90 into red-hat-storage:main Oct 30, 2025
15 checks passed
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Oct 30, 2025

@iamniting: new pull request created: #697

Details

In response to this:

/cherry-pick release-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 30, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nb-ohad nb-ohad nb-ohad requested changes

@iamniting iamniting iamniting approved these changes

Assignees

@nb-ohad nb-ohad

@iamniting iamniting

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rohan47 @iamniting @openshift-cherrypick-robot @ezio-auditore @nb-ohad