Syncing latest changes from main for odf-operator #727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Approve InstallPlans only after OLM reaches RequiresApproval OLM creates an initial InstallPlan that was approved immediately by the ODF operator while OLM was still processing it. OLM then detected the change as a modification conflict, treated the InstallPlan as invalid, and created a second duplicate InstallPlan. Subscriptions were updated to point to the new InstallPlan, which remained unapproved and caused upgrades to get stuck in UpgradePending. To prevent this, InstallPlans are now approved only after they reach the RequiresApproval phase, indicating that OLM has finished processing and is explicitly waiting for an external approver. This avoids the conflict, prevents duplicate InstallPlans, and ensures upgrades complete successfully. Signed-off-by: Nitin Goyal <[email protected]>
iamniting
approved these changes
Jan 22, 2026
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: df-build-team, iamniting The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR containing the latest commits from main branch