Skip to content

REDSHOP-6074 Coupon - Message show not fine when user save item missing Value #5580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CongThuong wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

REDSHOP-6074 Coupon - Message show not fine when user save item missing Value #5580

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions component/admin/language/en-GB/en-GB.com_redshop.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4687,6 +4687,7 @@ COM_REDSHOP_COUPON_REMAINING_AMOUNT = "Unused Amount"
COM_REDSHOP_COUPON_ERROR_CODE_ALREADY_EXIST = "Oops! Coupon Code already exists."
COM_REDSHOP_CONFIG_SUM_COUPON_SPECIFIC="Sum value coupon"
COM_REDSHOP_CONFIG_SUM_COUPON_SPECIFIC_DESC="Sum coupon description"
COM_REDSHOP_COUPON_ENTER_FIELD_VALUE = "Please Enter field value"

; Vouchers
COM_REDSHOP_VOUCHER_MANAGEMENT = "Voucher Management"
Expand Down
7 changes: 7 additions & 0 deletions component/admin/models/coupon.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,13 @@ public function save($data)

return false;
}

if (empty($data['value'])) {
/** @scrutinizer ignore-deprecated */
$this->setError(JText::_('COM_REDSHOP_COUPON_ENTER_FIELD_VALUE'));

return false;
}

if (!empty($data['start_date'])) {
$data['start_date'] = \JFactory::getDate($data['start_date'])->toSql();
Expand Down