Skip to content

Revert "chore(deps): bump secrecy from 0.8.0 to 0.10.3 in /rook"#139

Merged
reddevilmidzy merged 1 commit intomainfrom
revert-135-dependabot/cargo/rook/secrecy-0.10.3
Jun 24, 2025
Merged

Revert "chore(deps): bump secrecy from 0.8.0 to 0.10.3 in /rook"#139
reddevilmidzy merged 1 commit intomainfrom
revert-135-dependabot/cargo/rook/secrecy-0.10.3

Conversation

@reddevilmidzy
Copy link
Owner

Reverts #135

Copilot AI review requested due to automatic review settings June 24, 2025 07:37
@github-actions github-actions bot added this to the 5차 MVP 구현 milestone Jun 24, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reverts the previous upgrade of the secrecy crate, aligning code back to use version 0.8 and removing SecretBox usages in favor of the newer Secret API.

  • Downgrade the secrecy dependency in Cargo.toml from 0.10 back to 0.8.
  • Replace all SecretBox types and initializers with Secret.
  • Update imports and deserializers to match the Secret type.

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
rook/src/main.rs Removed SecretBox usage in main, passing authorization_token.clone() directly to new().
rook/src/email_client.rs Swapped SecretBox for Secret in struct, imports, and test initializers.
rook/src/domain/email_verification.rs Replaced SecretBox with Secret for verification codes and added Clone derive.
rook/src/configuration.rs Adjusted config field and deserializer to produce Secret<String> instead of SecretBox.
rook/Cargo.toml Downgraded secrecy crate dependency to version 0.8.
Comments suppressed due to low confidence (1)

rook/Cargo.toml:31

  • The crate version for secrecy is downgraded to 0.8, but the code now uses Secret, which was introduced in later versions. This mismatch will cause compilation errors; either restore the crate to v0.10 or revert code changes to use SecretBox.
secrecy = { version = "0.8", features = ["serde"] }

@reddevilmidzy reddevilmidzy merged commit 2c6ad9f into main Jun 24, 2025
3 checks passed
@reddevilmidzy reddevilmidzy deleted the revert-135-dependabot/cargo/rook/secrecy-0.10.3 branch June 24, 2025 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants