Revert "chore(deps): bump secrecy from 0.8.0 to 0.10.3 in /rook"#139
Merged
reddevilmidzy merged 1 commit intomainfrom Jun 24, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR reverts the previous upgrade of the secrecy crate, aligning code back to use version 0.8 and removing SecretBox usages in favor of the newer Secret API.
- Downgrade the
secrecydependency in Cargo.toml from 0.10 back to 0.8. - Replace all
SecretBoxtypes and initializers withSecret. - Update imports and deserializers to match the
Secrettype.
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| rook/src/main.rs | Removed SecretBox usage in main, passing authorization_token.clone() directly to new(). |
| rook/src/email_client.rs | Swapped SecretBox for Secret in struct, imports, and test initializers. |
| rook/src/domain/email_verification.rs | Replaced SecretBox with Secret for verification codes and added Clone derive. |
| rook/src/configuration.rs | Adjusted config field and deserializer to produce Secret<String> instead of SecretBox. |
| rook/Cargo.toml | Downgraded secrecy crate dependency to version 0.8. |
Comments suppressed due to low confidence (1)
rook/Cargo.toml:31
- The crate version for
secrecyis downgraded to 0.8, but the code now usesSecret, which was introduced in later versions. This mismatch will cause compilation errors; either restore the crate to v0.10 or revert code changes to useSecretBox.
secrecy = { version = "0.8", features = ["serde"] }
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #135