test: add configuration loading test and convert string test#172
Merged
reddevilmidzy merged 1 commit intomainfrom Jul 15, 2025
Merged
test: add configuration loading test and convert string test#172reddevilmidzy merged 1 commit intomainfrom
reddevilmidzy merged 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds unit tests for environment string conversion and local configuration loading, and ensures Environment can be compared in tests.
- Derive
PartialEqandEqon theEnvironmentenum to support equality assertions. - Add tests for
Environment::as_str(),TryFrom<String>onEnvironment, andget_local_configuration().
Comments suppressed due to low confidence (1)
rook/src/configuration.rs:175
- We have a test for loading local settings but no test for
get_production_configuration. Adding a similar test for production configs will ensure both code paths are verified and improve overall coverage.
fn test_get_local_configuration() -> Result<(), config::ConfigError> {
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Owner
Author
|
음 왜 codecov comment에 커버리지를 퍼센테이지로 안알려주지 :( |
Owner
Author
|
@codecov-ai-reviewer review |
This comment has been minimized.
This comment has been minimized.
|
Seer failed to run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
♟️ What’s this PR about?
local configuration 불러오는 테스트와 환경이 문자열로 주어졌을 때 Enviroment struct로 변환하는 로직 테스트를 추가하였습니다. (빨리도 한다..ㅎ)
🔗 Related Issues / PRs