test: add test for get production configuration#174
Merged
reddevilmidzy merged 1 commit intomainfrom Jul 15, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds a unit test for the get_production_configuration function and pulls in the shuttle-common crate to access secret types in tests.
- Imports
SecretandBTreeMapand definestest_get_production_configuration. - Adds
shuttle-common = "0.56.0"toCargo.toml.
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| rook/src/configuration.rs | Imported secret types and added a new positive test |
| rook/Cargo.toml | Added shuttle-common dependency |
Comments suppressed due to low confidence (2)
rook/src/configuration.rs:208
- The test verifies
sender_emailandtimeout_secondsbut misses asserting thatauthorization_tokenis correctly applied from secrets. Consider addingassert_eq!(settings.email_client.authorization_token, "veryverysecret");.
assert_eq!(settings.email_client.timeout_seconds, 10);
rook/src/configuration.rs:148
- The test references
SecretStorebut it isn’t imported. Adduse shuttle_common::secrets::SecretStore;to ensure the code compiles.
use shuttle_common::secrets::Secret;
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
2b62463 to
46bdc62
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
♟️ What’s this PR about?
production 환경에서 Secret 값을 가져와 설정 추가하는 로직에 대한 테스트를 추가하였습니다.