Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR switches the coverage tool from Tarpaulin to LLVM-cov, updates the CI caching and upload steps accordingly, removes the legacy Codecov configuration, and adds a new unit test for EmailVerification::new.
- Add
test_create_email_verificationto verify email assignment and timestamp ordering. - Update
.github/workflows/rust.ymlto cache and run coverage withcargo llvm-cov. - Remove
.github/codecov.ymlfile which held legacy coverage thresholds.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| rook/src/domain/email_verification.rs | Added a new test for EmailVerification::new |
| .github/workflows/rust.yml | Switched CI coverage from Tarpaulin to LLVM-cov and updated cache keys |
| .github/codecov.yml | Removed old Codecov configuration |
Comments suppressed due to low confidence (3)
.github/workflows/rust.yml:156
- [nitpick] If your repository uses multiple crates or a workspace-level Cargo.lock, consider using a wildcard like
**/Cargo.lockinhashFilesto ensure the cache key updates whenever any lockfile changes.
key: ${{ runner.os }}-cargo-registry-${{ hashFiles('rook/Cargo.lock') }}
rook/src/domain/email_verification.rs:195
- Consider extending this test to also assert that the generated secret code matches the expected 6-digit numeric pattern (e.g., reuse the logic from existing tests) to increase coverage of the code generation path.
assert_eq!(verification.email, email);
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
♟️ What’s this PR about?
여전히 의도대로 안되는 codecov,,,,
🔗 Related Issues / PRs