Skip to content

llvm-cov로 변경한 후 테스트 추가 시나리오#180

Closed
reddevilmidzy wants to merge 2 commits intomainfrom
test2-email
Closed

llvm-cov로 변경한 후 테스트 추가 시나리오#180
reddevilmidzy wants to merge 2 commits intomainfrom
test2-email

Conversation

@reddevilmidzy
Copy link
Owner

♟️ What’s this PR about?

여전히 의도대로 안되는 codecov,,,,

🔗 Related Issues / PRs

Copilot AI review requested due to automatic review settings July 16, 2025 05:36
@github-actions github-actions bot added this to the 5차 MVP 구현 milestone Jul 16, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR switches the coverage tool from Tarpaulin to LLVM-cov, updates the CI caching and upload steps accordingly, removes the legacy Codecov configuration, and adds a new unit test for EmailVerification::new.

  • Add test_create_email_verification to verify email assignment and timestamp ordering.
  • Update .github/workflows/rust.yml to cache and run coverage with cargo llvm-cov.
  • Remove .github/codecov.yml file which held legacy coverage thresholds.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
rook/src/domain/email_verification.rs Added a new test for EmailVerification::new
.github/workflows/rust.yml Switched CI coverage from Tarpaulin to LLVM-cov and updated cache keys
.github/codecov.yml Removed old Codecov configuration
Comments suppressed due to low confidence (3)

.github/workflows/rust.yml:156

  • [nitpick] If your repository uses multiple crates or a workspace-level Cargo.lock, consider using a wildcard like **/Cargo.lock in hashFiles to ensure the cache key updates whenever any lockfile changes.
          key: ${{ runner.os }}-cargo-registry-${{ hashFiles('rook/Cargo.lock') }}

rook/src/domain/email_verification.rs:195

  • Consider extending this test to also assert that the generated secret code matches the expected 6-digit numeric pattern (e.g., reuse the logic from existing tests) to increase coverage of the code generation path.
        assert_eq!(verification.email, email);

@codecov
Copy link

codecov bot commented Jul 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@reddevilmidzy reddevilmidzy deleted the test2-email branch July 16, 2025 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants