test: add test creating email verification#183
Closed
reddevilmidzy wants to merge 1 commit intomainfrom
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a unit test for the EmailVerification::new method to verify basic functionality of email verification creation. The test ensures that the email is properly stored and that the expiration time is set after the creation time.
- Adds a new test case
test_create_email_verificationthat validates email verification object creation
Comments suppressed due to low confidence (2)
rook/src/domain/email_verification.rs:192
- [nitpick] The test name 'test_create_email_verification' is redundant since it's already in a test context. Consider renaming to 'create_email_verification_sets_correct_fields' or 'new_creates_valid_email_verification' to better describe what is being tested.
fn test_create_email_verification() {
rook/src/domain/email_verification.rs:196
- The test only verifies that expires_at is after created_at, but doesn't validate the actual expiration duration. Consider adding an assertion to verify the expiration time is set to the expected duration (e.g., checking if it's within a reasonable range).
assert!(verification.expires_at > verification.created_at);
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Owner
Author
|
@codecov-ai-reviewer review |
This comment has been minimized.
This comment has been minimized.
|
Seer failed to run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
♟️ What’s this PR about?
다시 한번 테스트 추가 #178 와 동일