Skip to content

test: add test creating email verification#183

Closed
reddevilmidzy wants to merge 1 commit intomainfrom
re-test
Closed

test: add test creating email verification#183
reddevilmidzy wants to merge 1 commit intomainfrom
re-test

Conversation

@reddevilmidzy
Copy link
Owner

♟️ What’s this PR about?

다시 한번 테스트 추가 #178 와 동일

Copilot AI review requested due to automatic review settings July 16, 2025 07:33
@github-actions github-actions bot added this to the 5차 MVP 구현 milestone Jul 16, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a unit test for the EmailVerification::new method to verify basic functionality of email verification creation. The test ensures that the email is properly stored and that the expiration time is set after the creation time.

  • Adds a new test case test_create_email_verification that validates email verification object creation
Comments suppressed due to low confidence (2)

rook/src/domain/email_verification.rs:192

  • [nitpick] The test name 'test_create_email_verification' is redundant since it's already in a test context. Consider renaming to 'create_email_verification_sets_correct_fields' or 'new_creates_valid_email_verification' to better describe what is being tested.
    fn test_create_email_verification() {

rook/src/domain/email_verification.rs:196

  • The test only verifies that expires_at is after created_at, but doesn't validate the actual expiration duration. Consider adding an assertion to verify the expiration time is set to the expected duration (e.g., checking if it's within a reasonable range).
        assert!(verification.expires_at > verification.created_at);

@codecov
Copy link

codecov bot commented Jul 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@reddevilmidzy
Copy link
Owner Author

@codecov-ai-reviewer review

@codecov-ai

This comment has been minimized.

@codecov-ai
Copy link

codecov-ai bot commented Jul 16, 2025

Seer failed to run.

@reddevilmidzy reddevilmidzy deleted the re-test branch July 16, 2025 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants