Move from rook directory to root directory#189
Conversation
WalkthroughThe changes shift configuration, workflow, and ignore patterns from the Changes
Estimated code review effort1 (~6 minutes) Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Pull Request Overview
This PR moves the Rust project structure from a nested rook/ directory to the root directory of the repository. This reorganization simplifies the project layout and eliminates the need for subdirectory-specific configurations.
Key changes:
- Relocated Rust project files from
rook/subdirectory to repository root - Updated CI/CD workflows to remove
working-directoryspecifications - Modified configuration paths in GitHub Actions and Dependabot to point to root directory
Reviewed Changes
Copilot reviewed 6 out of 51 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| rook/.gitignore | Removed gitignore file from old rook directory |
| pawn/.gitkeep | Removed placeholder file from pawn directory |
| Cargo.toml | Updated readme path to point to root directory |
| .github/workflows/shuttle_deploy.yml | Removed working-directory specification for shuttle deployment |
| .github/workflows/rust.yml | Updated all cargo commands and paths to work from root directory |
| .github/dependabot.yml | Changed cargo directory monitoring from /rook/ to root |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🔭 Outside diff range comments (1)
Cargo.toml (1)
4-9:edition = "2024"is not yet stable – CI will breakRust editions released so far are 2015, 2018 and 2021.
Using the unreleased2024edition will causecargoto fail on stable, beta and nightly toolchains.- edition = "2024" + edition = "2021"Update the edition (and run
cargo fix --edition) before merging.
🧹 Nitpick comments (2)
.gitignore (1)
1-10: Nice generalisation – consider a few extra common entriesYou might also want to ignore OS-specific noise files:
+# macOS +.DS_Store + +# Windows +Thumbs.db +Desktop.ini.github/workflows/rust.yml (1)
55-57: Avoid cache-key & path duplicationThe same cache stanza appears in four jobs. Extract into a reusable composite action or use a job-level
strategy.matrixwith a single step to keep the workflow DRY.Illustrative snippet:
- name: Cache Cargo uses: actions/cache@v4 with: path: | ~/.cargo/registry ~/.cargo/git target key: ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }}Also applies to: 81-83, 117-119, 158-161
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (7)
.github/dependabot.yml(1 hunks).github/workflows/rust.yml(6 hunks).github/workflows/shuttle_deploy.yml(0 hunks).gitignore(1 hunks)Cargo.toml(1 hunks)pawn/.gitkeep(0 hunks)rook/.gitignore(0 hunks)
💤 Files with no reviewable changes (3)
- pawn/.gitkeep
- .github/workflows/shuttle_deploy.yml
- rook/.gitignore
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build
🔇 Additional comments (4)
.github/dependabot.yml (1)
10-12: Root-level scope looks good – double-check nested cratesChanging the Cargo directory to
/will work only if every publishable crate now lives at the repo root.
If you still keep additional crates/workspaces in sub-folders, Dependabot will ignore them.
Confirm the crate layout or add extra update blocks for each nested crate.Cargo.toml (1)
8-9: README path updated – ensure file really exists at rootThe manifest now points to
README.md. Make sure this file was actually moved to the repository root, otherwisecargo publishand doc links will error out..github/workflows/rust.yml (2)
33-36: Correct manifest path 👍Pointing
cargo-denyat./Cargo.tomlmatches the new layout. No issues spotted.
170-174: Coverage upload path matches build output
cargo llvm-covwriteslcov.infoat the working directory, so the updatedpath-to-lcovis correct.
Pull Request Test Coverage Report for Build 16438119497Details
💛 - Coveralls |
♟️ What’s this PR about?
Move from rook directory to root directory, and cargo update
Summary by CodeRabbit
.gitignoreto cover more general patterns and IDE/editor files.