feat: add dry-run argument for skip pull-request generating#234
feat: add dry-run argument for skip pull-request generating#234reddevilmidzy merged 1 commit intomainfrom
Conversation
WalkthroughAdds a dry-run CLI flag that gates link-check streaming in main. Modifies PullRequestGenerator by adding a new_content field to FileChange and internalizing default author info, removing corresponding constructor parameters. Tests were adjusted to reflect the new defaults and signature changes. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User
participant CLI as CLI (main)
participant Checker as stream_link_checks
User->>CLI: Run with args (--dry-run / -d)
alt dry_run == true
CLI->>Checker: stream_link_checks(repo, branch)
Checker-->>CLI: Result
opt error
CLI-->>User: Print error
end
else dry_run == false
Note over CLI: Skip stream_link_checks
end
CLI-->>User: Exit
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
src/git/pr_generator.rs(3 hunks)src/main.rs(2 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: reddevilmidzy
PR: reddevilmidzy/queensac#226
File: src/main.rs:21-32
Timestamp: 2025-09-22T15:50:19.531Z
Learning: User reddevilmidzy prefers to communicate in Korean and likes to keep PR scope focused and well-defined.
🧬 Code graph analysis (1)
src/main.rs (1)
src/link_checker/sse.rs (1)
stream_link_checks(79-158)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: test
🔇 Additional comments (1)
src/git/pr_generator.rs (1)
60-69: 내부 기본 author 설정 👍생성자에서 author 정보를 일관된 기본값으로 고정해 호출부 시그니처가 단순해졌네요. 팀 표준 커밋 서명을 강제하면서 호출 측 실수를 줄여줄 것 같습니다.
Pull Request Test Coverage Report for Build 18077226261Details
💛 - Coveralls |
♟️ What’s this PR about?
dry-run args를 추가하였습니다.
이제 다음 pr에선 저 코드를
main.rs가 아닌 다른 곳이로 이동 시킬 예정입니다.🔗 Related Issues / PRs
close: #231
Summary by CodeRabbit