Skip to content

Cargo.toml 업데이트#79

Merged
reddevilmidzy merged 1 commit intomainfrom
version
May 26, 2025
Merged

Cargo.toml 업데이트#79
reddevilmidzy merged 1 commit intomainfrom
version

Conversation

@reddevilmidzy
Copy link
Owner

♟️ What’s this PR about?

dependabot 이 알람을 띄운 idna 문제를 해결하면서 사용되고 있지 않았던 chrono 의존성은 제거하였고, validate, fake, quickcheck, quickcheck_macros, shuttle-axum, shuttle-runtime 의 버전을 올렸고, rand 의존성을 추가하였다.

🔗 Related Issues / PRs

close: #78

Copilot AI review requested due to automatic review settings May 26, 2025 09:13
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates dependency versions in Cargo.toml and aligns subscriber email validation and testing with the upgraded validator library.

  • Removed unused chrono dependency and updated versions for shuttle-axum, shuttle-runtime, validator, fake, quickcheck, and added rand.
  • Updated subscriber_email.rs to use the ValidateEmail trait for email validation and enhanced the test fixture by seeding RNG for generating valid emails.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
rook/src/domain/subscriber_email.rs Updated email validation to use the trait method and improved the test fixture setup with a seeded RNG.
rook/Cargo.toml Updated dependency versions and adjusted the readme path.

@reddevilmidzy
Copy link
Owner Author

image

깃헙이 마이 아픈것 같다.

@reddevilmidzy reddevilmidzy merged commit 7f52411 into main May 26, 2025
2 checks passed
@reddevilmidzy reddevilmidzy deleted the version branch May 26, 2025 09:22
@reddevilmidzy reddevilmidzy added this to the 3차 MVP 구현 milestone Jun 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

idna 버전 올리기

2 participants