Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates dependency versions in Cargo.toml and aligns subscriber email validation and testing with the upgraded validator library.
- Removed unused chrono dependency and updated versions for shuttle-axum, shuttle-runtime, validator, fake, quickcheck, and added rand.
- Updated subscriber_email.rs to use the ValidateEmail trait for email validation and enhanced the test fixture by seeding RNG for generating valid emails.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| rook/src/domain/subscriber_email.rs | Updated email validation to use the trait method and improved the test fixture setup with a seeded RNG. |
| rook/Cargo.toml | Updated dependency versions and adjusted the readme path. |
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

♟️ What’s this PR about?
dependabot 이 알람을 띄운 idna 문제를 해결하면서 사용되고 있지 않았던
chrono의존성은 제거하였고,validate,fake,quickcheck,quickcheck_macros,shuttle-axum,shuttle-runtime의 버전을 올렸고,rand의존성을 추가하였다.🔗 Related Issues / PRs
close: #78