This repository was archived by the owner on Sep 11, 2018. It is now read-only.
Increased right margin on close button#43
Open
mhweaver wants to merge 70 commits intoreddit-archive:masterfrom
Open
Increased right margin on close button#43mhweaver wants to merge 70 commits intoreddit-archive:masterfrom
mhweaver wants to merge 70 commits intoreddit-archive:masterfrom
Conversation
Merged with help from Justin Paupore <jpaupore@blueshiftlabs.net>.
Merged with help from Justin Paupore <jpaupore@blueshiftlabs.net>.
Merged with help from Justin Paupore <jpaupore@blueshiftlabs.net>.
Merged with help from Justin Paupore <jpaupore@blueshiftlabs.net>.
Merged with help from Justin Paupore <jpaupore@blueshiftlabs.net>.
HTML notifications from marklr:master.
Also, remove 9999px initial draw step.
This commit resurrects the old programmatic injection of the page overlay, which we must do for https pages since the content script no longer matches them. It also consolidates the various UI updates upon tab change / load into tabStatus.updateTab.
In OS X, the scroll bar tends to completely cover the close button. Shifting it slightly to the left allows the button to still be usable, even when the scroll bar is visible.
It makes more sense that the margin be part of the bar than the button.
Author
There was a problem hiding this comment.
Sorry for the sloppy commit. I couldn't do the change/commit properly and had to use the web interface. Mistakes were made; hearts were broken; lessons were learned.
|
For now, before the improvement, one could try turning on "hide scrollbar when not being used." Thus the user would have to wait for the scrollbar to disappear before clicking the X close button. This should be fixed, though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In OS X, the scroll bar tends to completely cover the close button.
Screenshot of issue
Shifting it slightly to the left allows the button to still be usable,
even when the scroll bar is visible, without it looking weird.