This repository was archived by the owner on Sep 11, 2018. It is now read-only.
allow the "show reddit information" button to appear on https websites#59
Open
sorahn wants to merge 1 commit intoreddit-archive:masterfrom
Open
allow the "show reddit information" button to appear on https websites#59sorahn wants to merge 1 commit intoreddit-archive:masterfrom
sorahn wants to merge 1 commit intoreddit-archive:masterfrom
Conversation
|
why isn't this enabled in the basic version of the extension? |
Author
|
The last time I asked @chromakode about this, they weren't taking the pull request because they had a brand spankin' new version of the companion almost ready to go, and it wouldn't be necessary, but then I never heard from him again :( |
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables the background.js reddit information function to run on https
domains. I updated the permissions in the manifest, and there is currently
a bug in webkit which requires the style-src 'unsafe-inline' directive.
See here: https://bugs.webkit.org/show_bug.cgi?id=112270