Skip to content
This repository was archived by the owner on Sep 11, 2018. It is now read-only.

Strip off '/r/' when scraping subreddit name.#68

Open
alienth wants to merge 2 commits intoreddit-archive:masterfrom
alienth:strip
Open

Strip off '/r/' when scraping subreddit name.#68
alienth wants to merge 2 commits intoreddit-archive:masterfrom
alienth:strip

Conversation

@alienth
Copy link

@alienth alienth commented Apr 27, 2014

The change adding the '/r/' to the subreddit link on the front page resulted in companion displaying subreddits as '/r//r/subreddit', when linking from the front page.

👓 @chromakode

@Smashman
Copy link

I actually addressed this issue in #67, over 2 weeks ago.

Your method is actually stripping the /r/ and then it's being reprepended later. My method simply removes the prepending of the /r/ in the first place.

Edit:
Oh, I see. The bonus /r/ is only being passed when linked from the frontpage.

Edit2:
Ok, that's because of the way that is obtained. Everything is clear now. In which case, your method is best. Though I think that JQuery should still be updated as the errors the current version leaves are a bit scary!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants