grpcbp: support conditional non-blocking mode #708
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnephin
requested review from
konradreiche,
mathyourlife-reddit and
pacejackson
and removed request for
a team
dnephin
force-pushed
the
dnephin/with-default-block
branch
from
c1f055b to
e2f7bc9
Compare
pacejackson
approved these changes
Jan 9, 2026
konradreiche
approved these changes
Jan 9, 2026
Co-authored-by: Konrad Reiche <[email protected]>
dnephin
commented
Jan 12, 2026
dnephin
commented
Jan 12, 2026
| // added to improve connection error messages and to set [grpc.WaitForReady] on all RPC calls. | ||
| func WithDefaultBlock() grpc.DialOption { | ||
| if strings.EqualFold(os.Getenv("REDDIT_RPC_CONNECTION_MODE"), "non-blocking") { | ||
| return grpc.WithChainUnaryInterceptor( |
Contributor
There was a problem hiding this comment.
what about stream connections? would grpc.WithDefaultCallOptions(grpc.WaitForReady(true)) provide what you're looking for?
Member
Author
There was a problem hiding this comment.
I'm not sure how to handle streaming connections. We'll have to revisit streaming connections later if we find some that are relevant.
WithDefaultCallOptions does seem like a better way to implement this!
Member
Author
|
I'm going to move this to a different repo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💸 TL;DR
We'd like to support non-blocking dials in dev, even if the service is configured to use
grpc.WithBlockin production.📜 Details
This PR adds a new
DialOptionthat can be used instead ofgrpc.WithBlock. When the dial option is used, and theREDDIT_RPC_CONNECTION_MODE=non-blockingenv var is set the dial will be non-blocking , and two interceptors will be added. The interceptors improve the connection error message by adding the hostname (similar to #707) and setWaitForReady(true)on all RPC requests. This way a request waits for a connection the full context timeout (instead of failing fast immediately if there is no connection).🧪 Testing Steps / Validation
Test added in this PR.
✅ Checks