Skip to content

feat(KONFLUX-9432): Adding kubearchive controllers #7426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(KONFLUX-9432): Adding kubearchive controllers #7426

wants to merge 1 commit into from
+1 −1

Conversation

jhutar
Copy link
Member

@jhutar jhutar commented Aug 1, 2025 •
edited
Loading

Just updating our dashboard.

@openshift-ci openshift-ci bot requested review from eisraeli and yftacherzog August 1, 2025 09:50
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Aug 1, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jhutar
Once this PR has been reviewed and has the lgtm label, please assign faisalal-rayes for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jhutar jhutar force-pushed the fix56-controllers-overview branch 4 times, most recently from 5e5cfc6 to 1bfecf3 Compare August 1, 2025 11:14
@jhutar
Copy link
Member Author

jhutar commented Aug 4, 2025

/retest

1 similar comment
@jhutar
Copy link
Member Author

jhutar commented Aug 14, 2025

/retest

@jhutar jhutar force-pushed the fix56-controllers-overview branch from 1bfecf3 to 59b9413 Compare August 26, 2025 11:55
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 26, 2025 •
edited by openshift-ci bot
Loading

Code Review by Gemini

The commit message and the code changes are inconsistent.

Issue:
The commit title feat([KONFLUX-9432](https://issues.redhat.com//browse/KONFLUX-9432)): Adding kubearchive controllers suggests the addition of new controllers, but the actual code change only updates a Git reference for a Grafana dashboard. This discrepancy can lead to confusion when reviewing the commit history and understanding the purpose of the change.

Suggestion for improvement:
Ensure the commit message accurately reflects the changes made in the pull request. If the only change is updating the Grafana dashboard reference, the commit title and body should clearly state that. If kubearchive controllers were intended to be added, those changes are missing from this diff.

No issues found in the kustomization.yaml file itself. The update of the Git reference is syntactically correct.

@jhutar
Copy link
Member Author

jhutar commented Aug 27, 2025 •
edited
Loading

Hello @mftb . In this PR I'm just trying to update some perf-related dashboard on in-cluster Grafana and CI keeps failing on me. Could you please recommend somebody from your team I could ask to help me understand what is happening and how to overcome it?

In gather-extra in *grafana* pod logs, I found these errors:

In appstudio-grafana_grafana-operator-controller-manager-v5-59b44cdb46-t77l4_manager.log:

2025-08-14T13:11:39.150Z	error	Reconciler error	{"controller": "grafanadashboard", "controllerGroup": "grafana.integreatly.org", "controllerKind": "GrafanaDashboard", "GrafanaDashboard": {"name":"controllers-overview","namespace":"appstudio-grafana"}, "namespace": "appstudio-grafana", "name": "controllers-overview", "reconcileID": "07a8b79e-a5e3-4232-a9b4-b30463d90fb2", "error": "resolving dashboard contents: failed to fetch contents: configmaps \"controllers-overview-dc566k7t25\" not found"}
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).reconcileHandler
	sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:347
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).processNextWorkItem
	sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:294
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).Start.func2.2
	sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:255

and (but I assume this is not relevant):

$ curl --silent https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/redhat-appstudio_infra-deployments/7426/pull-ci-redhat-appstudio-infra-deployments-main-appstudio-e2e-tests/1955974172349829120/artifacts/appstudio-e2e-tests/gather-extra/artifacts/pods/appstudio-grafana_grafana-oauth-deployment-74cb76fbff-8pw8k_grafana.log | grep error
logger=plugins.registration t=2025-08-14T13:11:54.5442221Z level=error msg="Could not register plugin" pluginId=xychart error="plugin xychart is already registered"
logger=plugins.initialization t=2025-08-14T13:11:54.544247675Z level=error msg="Could not initialize plugin" pluginId=xychart error="plugin xychart is already registered"

$ curl --silent https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/redhat-appstudio_infra-deployments/7426/pull-ci-redhat-appstudio-infra-deployments-main-appstudio-e2e-tests/1955974172349829120/artifacts/appstudio-e2e-tests/gather-extra/artifacts/pods/product-kubearchive-logging_vector-kubearchive-log-collector-grafana-6b8c4cb579-dd4ng_grafana.log | grep level=error
logger=plugins.registration t=2025-08-14T13:10:51.703915339Z level=error msg="Could not register plugin" pluginId=table error="plugin table is already registered"
logger=plugins.initialization t=2025-08-14T13:10:51.703934912Z level=error msg="Could not initialize plugin" pluginId=table error="plugin table is already registered"
logger=plugin.backgroundinstaller t=2025-08-14T13:10:51.943573298Z level=error msg="Failed to install plugin" pluginId=grafana-lokiexplore-app version= error="failed to create temporary file: open /tmp/2027371193.zip: read-only file system"
logger=plugin.backgroundinstaller t=2025-08-14T13:10:52.061419354Z level=error msg="Failed to install plugin" pluginId=grafana-pyroscope-app version= error="failed to create temporary file: open /tmp/3130128308.zip: read-only file system"
logger=plugin.backgroundinstaller t=2025-08-14T13:10:52.160766615Z level=error msg="Failed to install plugin" pluginId=grafana-exploretraces-app version= error="failed to create temporary file: open /tmp/3035487871.zip: read-only file system"
logger=plugin.backgroundinstaller t=2025-08-14T13:10:52.238865975Z level=error msg="Failed to install plugin" pluginId=grafana-metricsdrilldown-app version= error="failed to create temporary file: open /tmp/1995980529.zip: read-only file system"

@martysp21
Copy link

/retest

1 similar comment
@kubasikus
Copy link
Contributor

/retest

kubasikus added a commit that referenced this pull request Aug 29, 2025
@kubasikus
TEST COMMIT
afa20a1 
This commit reverts to older dashboards to check if the #7426 failures could be caused by issues with grafana dashboard definitions
@kubasikus kubasikus mentioned this pull request Aug 29, 2025
Open
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Aug 29, 2025

@jhutar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/appstudio-e2e-tests 59b9413 link true /test appstudio-e2e-tests
ci/prow/konflux-e2e-v416-optional 59b9413 link false /test konflux-e2e-v416-optional

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eisraeli eisraeli Awaiting requested review from eisraeli

@yftacherzog yftacherzog Awaiting requested review from yftacherzog

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jhutar @martysp21 @kubasikus