Skip to content

Conversation

kubasikus
Copy link
Contributor

This commit reverts to older dashboards to check if the #7426 failures could be caused by issues with grafana dashboard definitions

This commit reverts to older dashboards to check if the #7426 failures could be caused by issues with grafana dashboard definitions
@openshift-ci openshift-ci bot requested review from eisraeli and ifireball August 29, 2025 12:19
Copy link

openshift-ci bot commented Aug 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kubasikus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubasikus
Copy link
Contributor Author

/hold

Copy link
Contributor

Code Review by Gemini

The commit message states "reverts to older dashboards". However, the Git reference 66a1c0209636bf815b0945cf45215c5d03ae4413 points to a newer commit than 5b189cfab2e132d8365be08d529f031f70dddbb5 in the redhat-appstudio/perfscale repository. This contradicts the stated purpose of reverting to older dashboards.

To align the change with the commit message, the ref should point to a commit that is older than 5b189cfab2e132d8365be08d529f031f70dddbb5.

--- a/components/monitoring/grafana/base/dashboards/performance/kustomization.yaml
+++ b/components/monitoring/grafana/base/dashboards/performance/kustomization.yaml
@@ -1,5 +1,5 @@
 ---
 apiVersion: kustomize.config.k8s.io/v1beta1
 kind: Kustomization
 resources:
-  - https://github.com/redhat-appstudio/perfscale/grafana/?ref=5b189cfab2e132d8365be08d529f031f70dddbb5
+  - https://github.com/redhat-appstudio/perfscale/grafana/?ref=<AN_OLDER_COMMIT_HASH>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant