Skip to content

konflux-ci: add gangway-token & link to SA #7448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Prucek
Copy link

@Prucek Prucek commented Aug 4, 2025

After this PR is merged, there is no need to manually add the gangway token in the users namespace and the pipelines that will run the run-prowjob task will use this token.

@openshift-ci openshift-ci bot requested review from mmorhun and psturc August 4, 2025 10:05
Copy link

openshift-ci bot commented Aug 4, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Prucek
Once this PR has been reviewed and has the lgtm label, please assign lcarva for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Aug 4, 2025

Hi @Prucek. Thanks for your PR.

I'm waiting for a redhat-appstudio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@enkeefe00
Copy link
Contributor

/ok-to-test

@enkeefe00
Copy link
Contributor

/lgtm

Copy link
Member

@gbenhaim gbenhaim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I asked several question in slack about this change.
In addition, if we will choose to store the secret on vault, you would need to create an additional. ClusterSecretStore that has an allow list for the namespaces which need to consume this secret.

@gbenhaim
Copy link
Member

gbenhaim commented Aug 5, 2025

/hold

Copy link

openshift-ci bot commented Aug 5, 2025

New changes are detected. LGTM label has been removed.

Copy link

openshift-ci bot commented Aug 5, 2025

@Prucek: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/konflux-e2e-v416-optional be807bb link false /test konflux-e2e-v416-optional

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants