Skip to content

notification-service update #7510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from
Closed

Conversation

rh-tap-build-team[bot]
Copy link
Contributor

@rh-tap-build-team rh-tap-build-team bot commented Aug 6, 2025

@openshift-ci openshift-ci bot requested review from gbenhaim and ifireball August 6, 2025 18:50
@rh-tap-build-team rh-tap-build-team bot force-pushed the notification-service branch from d1e2d24 to bac1004 Compare August 8, 2025 04:26
Copy link
Contributor

github-actions bot commented Aug 8, 2025

Code Review by Gemini

The changes update the notification-service version referenced in the Kustomize configuration. This is a standard version bump.

--- a/components/notification-controller/development/kustomization.yaml
+++ b/components/notification-controller/development/kustomization.yaml
@@ -1,18 +1,18 @@
 apiVersion: kustomize.config.k8s.io/v1beta1
 kind: Kustomization
 
 resources:
-- https://github.com/konflux-ci/notification-service/config/default?ref=bb970d881e7851965ee8da106ba47b0ae7658c10
+- https://github.com/konflux-ci/notification-service/config/default?ref=dfeb85ffa8c9d28175b69fb1a6903380409814c8
 
 images:
   - name: quay.io/konflux-ci/notification-service
     newName: quay.io/konflux-ci/notification-service
-    newTag: bb970d881e7851965ee8da106ba47b0ae7658c10
+    newTag: dfeb85ffa8c9d28175b69fb1a6903380409814c8
 
 namespace: notification-controller
 
 patches:
   - path: topic_region_add.yaml
     target:
       name: notification-controller-controller-manager
       kind: Deployment

Copy link
Contributor

github-actions bot commented Aug 8, 2025

Code Review by Gemini

The changes update the notification-service version referenced in the Kustomize configurations for both development and staging environments.

Review Summary

The changes are syntactically correct and achieve the stated goal of updating the notification-service base and image tag to a newer commit hash (dfeb85ffa8c9d28175b69fb1a6903380409814c8).

Issues and Improvements

No bugs or issues were found in the provided code changes. The update is a straightforward version bump.

Suggestion:

While the code changes themselves are correct, it is crucial to ensure that the new commit hash dfeb85ffa8c9d28175b69fb1a6903380409814c8 correctly incorporates the mentioned PRs (konflux-ci/notification-service#265, konflux-ci/notification-service#279) and that the updated notification-service version has been thoroughly tested for compatibility and functionality in the target environments. This is a verification step rather than a code change.

Copy link

openshift-ci bot commented Aug 12, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rh-tap-build-team[bot]

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

Code Review by Gemini

The provided diff is empty, so there are no code changes to review. Please provide the code changes to proceed with the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants