Skip to content

Test commit to get Gemini to review #7529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

enkeefe00
Copy link
Contributor

No description provided.

@openshift-ci openshift-ci bot requested review from avi-biton and mmorhun August 7, 2025 13:42
Copy link

openshift-ci bot commented Aug 7, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: enkeefe00
Once this PR has been reviewed and has the lgtm label, please assign johnmcollier for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

github-actions bot commented Aug 7, 2025

Code Review by Gemini

```diff
--- a/hack/kueue-vm-quotas/update-kueue-vm-quotas.py
+++ b/hack/kueue-vm-quotas/update-kueue-vm-quotas.py
@@ -70,9 +70,8 @@
 
 
 def extract_local_platforms(value: str, quota: int = 1000) -> List[PlatformQuota]:
-    """Extract platform quotas from local-platforms config entry."""
     platforms = []
     # Split by comma and clean up whitespace and empty strings
-    platform_names = [name.strip() for name in value.split(',') if name.strip()]
+    platform_names = [name.strip() for name in value.split(',') if name.strip()]
     
     for platform_name in platform_names:
         # Convert platform names like "linux/amd64" to "linux-amd64"

Issue:
The variable value was incorrectly changed to values in the list comprehension, leading to a NameError as values is not defined in this scope.

Suggested change:

--- a/hack/kueue-vm-quotas/update-kueue-vm-quotas.py
+++ b/hack/kueue-vm-quotas/update-kueue-vm-quotas.py
@@ -70,9 +70,8 @@
 
 
 def extract_local_platforms(value: str, quota: int = 1000) -> List[PlatformQuota]:
-    """Extract platform quotas from local-platforms config entry."""
     platforms = []
     # Split by comma and clean up whitespace and empty strings
-    platform_names = [name.strip() for name in values.split(',') if name.strip()]
+    platform_names = [name.strip() for name in value.split(',') if name.strip()]
     
     for platform_name in platform_names:
         # Convert platform names like "linux/amd64" to "linux-amd64"

--- a/hack/new-cluster/tasks/github/github-app-flow.py
+++ b/hack/new-cluster/tasks/github/github-app-flow.py
@@ -111,12 +111,12 @@
             self.wfile.write(update.encode("utf-8"))
         self.wfile.write("Playbook will proceed... see your terminal.".encode("utf-8"))
 
 
 if __name__ == "__main__":
-    port = 8089
+    port_num = 8089
     server = http.server.HTTPServer(("", port), Handler)
     localurl = f"http://localhost:{port}"
     print(f"Opening {localurl} ...", file=sys.stderr)
     webbrowser.open(localurl)
     print(f"Serving form submission request on {localurl} ...", file=sys.stderr)
     server.handle_request()  # Handle the POST to github
     print(f"Awaiting redirect from github request on {localurl} ...", file=sys.stderr)

Issue:
The variable port was renamed to port_num, but its usages in http.server.HTTPServer and the localurl f-string were not updated, which will result in a NameError.

Suggested change:

--- a/hack/new-cluster/tasks/github/github-app-flow.py
+++ b/hack/new-cluster/tasks/github/github-app-flow.py
@@ -111,12 +111,12 @@
             self.wfile.write(update.encode("utf-8"))
         self.wfile.write("Playbook will proceed... see your terminal.".encode("utf-8"))
 
 
 if __name__ == "__main__":
-    port = 8089
+    port_num = 8089
-    server = http.server.HTTPServer(("", port), Handler)
-    localurl = f"http://localhost:{port}"
+    server = http.server.HTTPServer(("", port_num), Handler)
+    localurl = f"http://localhost:{port_num}"
     print(f"Opening {localurl} ...", file=sys.stderr)
     webbrowser.open(localurl)
     print(f"Serving form submission request on {localurl} ...", file=sys.stderr)
     server.handle_request()  # Handle the POST to github
     print(f"Awaiting redirect from github request on {localurl} ...", file=sys.stderr)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant