Skip to content

Remove member operator subscription on stg es-01 #7542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mshaposhnik
Copy link
Contributor

No description provided.

Copy link
Contributor

github-actions bot commented Aug 8, 2025

Code Review by Gemini

```diff
--- a/components/sandbox/toolchain-member-operator/staging/kflux-stg-es01/kustomization.yaml
+++ b/components/sandbox/toolchain-member-operator/staging/kflux-stg-es01/kustomization.yaml
@@ -1,4 +1,12 @@
 apiVersion: kustomize.config.k8s.io/v1beta1
 kind: Kustomization
 resources:
 - ../base
+patches:
+  - patch: |
+      $patch: delete
+      apiVersion: operators.coreos.com/v1alpha1
+      kind: Subscription
+      metadata:
+        name: dev-sandbox-member
+        namespace: toolchain-member-operator
\ No newline at end of file

Improvements:

  • Missing Newline at End of File:
    It is a common best practice to include a newline character at the end of text files. The current change introduces content without a trailing newline.

    # components/sandbox/toolchain-member-operator/staging/kflux-stg-es01/kustomization.yaml
    # Add a new line after the last line of the file.
    # The file should end with:
    #         namespace: toolchain-member-operator
    # (empty line)

@mshaposhnik mshaposhnik changed the title Remove member operator subscription on es-01 Remove member operator subscription on stg es-01 Aug 12, 2025
@mshaposhnik
Copy link
Contributor Author

@amisstea @ifireball can you guys confirm we are ok with proceeding with this change on eaas staging?

@amisstea
Copy link
Contributor

@mshaposhnik we can proceed with this change 👍

Copy link
Contributor

@sadlerap sadlerap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Aug 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mshaposhnik, sadlerap

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mshaposhnik
Copy link
Contributor Author

/retest

Copy link
Contributor

Code Review by Gemini

--- a/components/sandbox/toolchain-member-operator/staging/kflux-stg-es01/kustomization.yaml
+++ b/components/sandbox/toolchain-member-operator/staging/kflux-stg-es01/kustomization.yaml
@@ -1,4 +1,12 @@
 apiVersion: kustomize.config.k8s.io/v1beta1
 kind: Kustomization
 resources:
 - ../base
+patches:
+  - patch: |
+      $patch: delete
+      apiVersion: operators.coreos.com/v1alpha1
+      kind: Subscription
+      metadata:
+        name: dev-sandbox-member
+        namespace: toolchain-member-operator
\ No newline at end of file

Improvements:

  • Add a newline at the end of the file:
    apiVersion: kustomize.config.k8s.io/v1beta1
    kind: Kustomization
    resources:
    - ../base
    patches:
      - patch: |
          $patch: delete
          apiVersion: operators.coreos.com/v1alpha1
          kind: Subscription
          metadata:
            name: dev-sandbox-member
            namespace: toolchain-member-operator
    # Add an empty line here

@mshaposhnik
Copy link
Contributor Author

/check-required-labels

@mshaposhnik
Copy link
Contributor Author

/shrug

@mshaposhnik
Copy link
Contributor Author

/check-required-labels

@mshaposhnik mshaposhnik merged commit b49ab52 into redhat-appstudio:main Aug 12, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants