-
Notifications
You must be signed in to change notification settings - Fork 302
Remove member operator subscription on stg es-01 #7542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove member operator subscription on stg es-01 #7542
Conversation
Signed-off-by: Max Shaposhnyk <[email protected]>
Code Review by Gemini```diff
--- a/components/sandbox/toolchain-member-operator/staging/kflux-stg-es01/kustomization.yaml
+++ b/components/sandbox/toolchain-member-operator/staging/kflux-stg-es01/kustomization.yaml
@@ -1,4 +1,12 @@
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
resources:
- ../base
+patches:
+ - patch: |
+ $patch: delete
+ apiVersion: operators.coreos.com/v1alpha1
+ kind: Subscription
+ metadata:
+ name: dev-sandbox-member
+ namespace: toolchain-member-operator
\ No newline at end of file Improvements:
|
@amisstea @ifireball can you guys confirm we are ok with proceeding with this change on eaas staging? |
@mshaposhnik we can proceed with this change 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mshaposhnik, sadlerap The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Code Review by Gemini--- a/components/sandbox/toolchain-member-operator/staging/kflux-stg-es01/kustomization.yaml
+++ b/components/sandbox/toolchain-member-operator/staging/kflux-stg-es01/kustomization.yaml
@@ -1,4 +1,12 @@
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
resources:
- ../base
+patches:
+ - patch: |
+ $patch: delete
+ apiVersion: operators.coreos.com/v1alpha1
+ kind: Subscription
+ metadata:
+ name: dev-sandbox-member
+ namespace: toolchain-member-operator
\ No newline at end of file Improvements:
|
/check-required-labels |
/shrug |
/check-required-labels |
No description provided.