Skip to content

mintmaker update #7555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from
Closed

mintmaker update #7555

wants to merge 0 commits into from

Conversation

rh-tap-build-team[bot]
Copy link
Contributor

@rh-tap-build-team rh-tap-build-team bot commented Aug 9, 2025

@openshift-ci openshift-ci bot requested review from querti and scoheb August 9, 2025 20:36
Copy link
Contributor

github-actions bot commented Aug 9, 2025

Code Review by Gemini

The changes consistently update the mintmaker component's Git reference and image tag across both development and staging environments. This appears to be a standard version update.

No bugs or issues were found in the provided code changes.

Suggestions for improvement:

  • Verify mintmaker-renovate-image update:
    Ensure that the newTag for quay.io/konflux-ci/mintmaker-renovate-image in components/mintmaker/staging/base/kustomization.yaml is intentionally kept at eebfc799ae059998dfbc1588ed44cc81a920a8ad. If this image is also part of the mintmaker release cycle or has dependencies on the updated mintmaker version, it might also need to be updated to a newer tag.

    --- a/components/mintmaker/staging/base/kustomization.yaml
    +++ b/components/mintmaker/staging/base/kustomization.yaml
    @@ -21,7 +21,7 @@
     - name: quay.io/konflux-ci/mintmaker-renovate-image
       newName: quay.io/konflux-ci/mintmaker-renovate-image
       newTag: eebfc799ae059998dfbc1588ed44cc81a920a8ad

    (No change needed if the current tag is correct for this update.)

@KristianTkacik
Copy link

/approve
/lgtm

@KristianTkacik
Copy link

/approve cancel

@openshift-ci openshift-ci bot removed the approved label Aug 11, 2025
@KristianTkacik
Copy link

/lgtm cancel

@openshift-ci openshift-ci bot removed the lgtm label Aug 11, 2025
@KristianTkacik
Copy link

/retest

1 similar comment
@staticf0x
Copy link
Contributor

/retest

Copy link

openshift-ci bot commented Aug 12, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rh-tap-build-team[bot]

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

Code Review by Gemini

The provided diff is empty, indicating that no code changes were included for review. Please provide the code changes to proceed with the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants