Skip to content

Conversation

@tecarter94
Copy link
Contributor

Make byte buffer size configurable. Add configurable whitelist of proxy targets. Factor out common IO code. Switch to using Vert.x server. Add support for HTTPS. Handle exceptions seen when connection dies between client and server. Refactored domain proxy in general for consistency.

https://issues.redhat.com/browse/JBS-23

…xy targets. Factor out common IO code. Switch to using Vert.x server. Add support for HTTPS. Handle exceptions seen when connection dies between client and server. Refactored domain proxy in general for consistency.
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 18, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@tecarter94
Copy link
Contributor Author

tecarter94 commented Oct 18, 2024

Unit tests still need to be added.

@codecov
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 46.89655% with 77 lines in your changes missing coverage. Please review.

Project coverage is 44.04%. Comparing base (6beffb2) to head (f5dd234).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
.../redhat/hacbs/domainproxy/common/CommonIOUtil.java 0.00% 47 Missing ⚠️
...edhat/hacbs/domainproxy/ExternalProxyVerticle.java 74.32% 13 Missing and 6 partials ⚠️
...om/redhat/hacbs/domainproxy/DomainProxyServer.java 47.61% 11 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2199      +/-   ##
============================================
+ Coverage     43.97%   44.04%   +0.06%     
- Complexity      795      811      +16     
============================================
  Files           275      276       +1     
  Lines         13396    13464      +68     
  Branches       1356     1360       +4     
============================================
+ Hits           5891     5930      +39     
- Misses         6889     6912      +23     
- Partials        616      622       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tecarter94
Copy link
Contributor Author

/test all

@tecarter94 tecarter94 marked this pull request as ready for review October 23, 2024 02:13
@openshift-ci openshift-ci bot requested review from rnc and vibe13 October 23, 2024 02:13
@tecarter94 tecarter94 requested review from matejonnet and removed request for vibe13 October 23, 2024 02:13
@openshift-ci openshift-ci bot added the lgtm label Oct 23, 2024
@tecarter94 tecarter94 merged commit 1544273 into redhat-appstudio:main Oct 23, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants