Skip to content

Conversation

@rnc
Copy link
Collaborator

@rnc rnc commented Oct 25, 2024

…tings.xml

For JBS-50

@openshift-ci openshift-ci bot requested a review from vibe13 October 25, 2024 13:16
@codecov
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 68.42105% with 6 lines in your changes missing coverage. Please review.

Project coverage is 44.04%. Comparing base (f919901) to head (6e00224).
Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
...eploy/mavenrepository/MavenRepositoryDeployer.java 64.70% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2229      +/-   ##
============================================
+ Coverage     44.02%   44.04%   +0.01%     
  Complexity      811      811              
============================================
  Files           276      276              
  Lines         13464    13474      +10     
  Branches       1360     1363       +3     
============================================
+ Hits           5927     5934       +7     
- Misses         6914     6915       +1     
- Partials        623      625       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rnc
Copy link
Collaborator Author

rnc commented Oct 25, 2024

This currently isn't passing custom settings.xml locations through ; I think this would need #2224 and then something like 5dc0a2d

@ruhan1
Copy link
Contributor

ruhan1 commented Oct 27, 2024

Looks good to me. Have you tried '-Dmaven.settings=path-to-custom-settings.xml'? for passing custom settings.xml location.

@rnc
Copy link
Collaborator Author

rnc commented Oct 27, 2024

@ruhan1 Thats a good point ; I haven't; that would probably work as well as long as its passed via the task yaml params. I guess I was going for the argument value in 5dc0a2d for consistency

@ruhan1
Copy link
Contributor

ruhan1 commented Oct 28, 2024

Yeah, that looks good. pls merge them so I can try it.

@openshift-ci openshift-ci bot added the lgtm label Oct 28, 2024
@rnc rnc merged commit ab9e20d into redhat-appstudio:main Oct 28, 2024
26 checks passed
@rnc rnc deleted the MVNDEPLOY branch October 28, 2024 10:22
@rnc rnc mentioned this pull request Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants