sed compatibility for non-GNU systems in ci-test

sed behaves differently depending on if it is the GNU version
or the BSD version
In the BSD version, using sed -i requires setting a backup
(which can be empty)

Signed-off-by: Tomáš Nevrlka <[email protected]>

Author: tnevrlka

ci-test.sh

@@ -3,6 +3,18 @@ source setup-local-dev-repos.sh
 source init-tas-vars.sh
 eval "$(hack/get-trustification-env.sh)"
 
+# sed behaves differently on different platforms
+# sed --version is not valid on BSD, while it is valid on the GNU version
+SED_CMD() {
+    if sed --version > /dev/null 2>&1; then
+        # GNU version
+        sed -i "$@"
+    else
+        # BSD version
+        sed -i "" "$@"
+    fi
+}
+
 # setting secrets for the dev repos is slow
 # after the first setting, you can skip this step
 # warning, if your secrets are stale, do not skip this step
@@ -34,9 +46,9 @@ function updateGitAndQuayRefs() {
         echo "USE_RHTAP_IMAGES is set to $USE_RHTAP_IMAGES"
         echo "images or Jenkins references patched to quay.io/$MY_QUAY_USER and github.com/$MY_GITHUB_USER"
         if [ -f "$1" ]; then
-            sed -i "s!quay.io/redhat-appstudio/rhtap-task-runner.*!quay.io/$MY_QUAY_USER/rhtap-task-runner:dev!g" "$1"
-            sed -i "s!https://github.com/redhat-appstudio!https://github.com/$MY_GITHUB_USER!g" "$1"
-            sed -i "s!RHTAP_Jenkins@.*'!RHTAP_Jenkins@dev'!g" "$1"
+            SED_CMD "s!quay.io/redhat-appstudio/rhtap-task-runner.*!quay.io/$MY_QUAY_USER/rhtap-task-runner:dev!g" "$1"
+            SED_CMD "s!https://github.com/redhat-appstudio!https://github.com/$MY_GITHUB_USER!g" "$1"
+            SED_CMD "s!RHTAP_Jenkins@.*'!RHTAP_Jenkins@dev'!g" "$1"
         fi
     fi
 }
@@ -47,14 +59,14 @@ function updateBuild() {
     mkdir -p "$REPO/rhtap"
     SETUP_ENV=$REPO/rhtap/env.sh
     cp rhtap/env.template.sh "$SETUP_ENV"
-    sed -i "s!\${{ values.image }}!$IMAGE_TO_BUILD!g" "$SETUP_ENV"
-    sed -i "s!\${{ values.dockerfile }}!Dockerfile!g" "$SETUP_ENV"
-    sed -i "s!\${{ values.buildContext }}!.!g" "$SETUP_ENV"
-    sed -i "s!\${{ values.repoURL }}!$GITOPS_REPO_UPDATE!g" "$SETUP_ENV"
+    SED_CMD "s!\${{ values.image }}!$IMAGE_TO_BUILD!g" "$SETUP_ENV"
+    SED_CMD "s!\${{ values.dockerfile }}!Dockerfile!g" "$SETUP_ENV"
+    SED_CMD "s!\${{ values.buildContext }}!.!g" "$SETUP_ENV"
+    SED_CMD "s!\${{ values.repoURL }}!$GITOPS_REPO_UPDATE!g" "$SETUP_ENV"
     # Update REKOR_HOST and TUF_MIRROR values directly
-    sed -i '/export REKOR_HOST=/d' "$SETUP_ENV"
-    sed -i '/export TUF_MIRROR=/d' "$SETUP_ENV"
-    sed -i '/export IGNORE_REKOR=/d' "$SETUP_ENV"
+    SED_CMD '/export REKOR_HOST=/d' "$SETUP_ENV"
+    SED_CMD '/export TUF_MIRROR=/d' "$SETUP_ENV"
+    SED_CMD '/export IGNORE_REKOR=/d' "$SETUP_ENV"
 
     {
         echo ""
@@ -66,7 +78,7 @@ function updateBuild() {
 
     if [[ "$TEST_PRIVATE_REGISTRY" == "true" ]]; then
         echo "WARNING Due to private repos, disabling ACS"
-        sed -i '/export DISABLE_ACS=/d' "$SETUP_ENV"
+        SED_CMD '/export DISABLE_ACS=/d' "$SETUP_ENV"
         echo "export DISABLE_ACS=true" >> "$SETUP_ENV"
     fi