expose REKOR and TUF in GH Actions and Jenkins#108
Merged
lcarva merged 2 commits intoredhat-appstudio:mainfrom Jan 22, 2025
Merged
expose REKOR and TUF in GH Actions and Jenkins#108lcarva merged 2 commits intoredhat-appstudio:mainfrom
lcarva merged 2 commits intoredhat-appstudio:mainfrom
Conversation
tnevrlka
force-pushed
the
load-rekor-tuf-secrets
branch
2 times, most recently
from
1b349b8 to
0d2fa8b
Compare
tnevrlka
force-pushed
the
load-rekor-tuf-secrets
branch
from
0d2fa8b to
4caf399
Compare
simonbaird
approved these changes
Jan 20, 2025
Member
|
Not sure what the policy is currently, but I'm happy to merge it. |
Member
|
I'd like to make sure we're happy with the changes in redhat-appstudio/tssc-sample-templates#106 before merging them here. |
REKOR_HOST and TUF_MIRROR are not exposed and can't be set by users in secrets/credentials in GH Actions and Jenkins Expose them in GH Actions. When getting an environment variable from secrets, GitHub always creates an env var, it just sets it to an empty string when secret is not set. This is going to be handled in env.sh in template definitions Add them to Jenkins too, but leave them commented out and let users uncomment them when needed
The automatically generated GitHub Actions workflows include a step which checks that exposed environment variables are actually set. `REKOR_HOST` and `TUF_MIRROR` should not be required and there is currently no way to easily mark the env vars as not required for the required check step. Comment them out and let users uncomment them when they want to use an external instance
tnevrlka
force-pushed
the
load-rekor-tuf-secrets
branch
from
4caf399 to
541656b
Compare
lcarva
approved these changes
Jan 22, 2025
dperaza4dustbit
pushed a commit
to dperaza4dustbit/tssc-dev-multi-ci
that referenced
this pull request
Dec 15, 2025
feat: split gitops resources in their own namespace
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
REKOR_HOST and TUF_MIRROR are not exposed and can't be set by users in secrets/credentials in GH Actions and Jenkins
Expose them in GH Actions.
When getting an environment variable from secrets, GitHub always creates an env var, it just sets it to an empty string when secret is not set. This is going to be handled in env.sh in template definitions
Add them to Jenkins too, but leave them commented out and let users uncomment them when needed
Related redhat-appstudio/tssc-sample-templates#106