Skip to content

Feedback review#3376

Open
dcurran90 wants to merge 2 commits intoredhat-best-practices-for-k8s:mainfrom
dcurran90:feedback_review
Open

Feedback review#3376
dcurran90 wants to merge 2 commits intoredhat-best-practices-for-k8s:mainfrom
dcurran90:feedback_review

Conversation

@dcurran90
Copy link
Copy Markdown

Adds a section for a response/review for feedback on failed certsuite tests in the results.html

BLOCKED: This PR depends on changes in redhat-best-practices-for-k8s/parser#89.

closes #3267

@dcibot
Copy link
Copy Markdown
Collaborator

dcibot commented Dec 17, 2025

@ramperher
Copy link
Copy Markdown
Collaborator

How is this feedback review block going to appear in the HTML report? I'm checking the autogenerated report in the last DCI job and I don't see any difference with current executions with stable branch.
Note that we use the feedback text block to automatically include the feedback with DCI, we create the feedback.jsfile that is embedded in the HTML web page, so that the feedback appears when you open it. We're interested in knowing if this feature will change or not in this change, so that we can apply the proper modifications in our side.

@dcurran90
Copy link
Copy Markdown
Author

dcurran90 commented Dec 23, 2025

hi @ramperher
here are some screenshots that I believe will answer your questions.

Feedback Response in UI
feedbackResponseUI

Downloaded JSON
feedbackResponseJSON

@ramperher
Copy link
Copy Markdown
Collaborator

@dcurran90 , thanks for your response. However, in the last, passed DCI job, I cannot see this new Feedback response block. It's still just showing the Feedback block:

Screenshot From 2025-12-26 09-16-13

Is there something that is missed in the certsuite code?

@dcurran90
Copy link
Copy Markdown
Author

I see what you mean now. It's blocked by the changes to the parser located here
Once that is merged/released this PR should work appropriately and the changes reflected in the DCI run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add Red Hat review comments window in result.html

3 participants