refactor: deduplicate PDB replica handling and test helpers#3506
Merged
sebrandon1 merged 1 commit intoredhat-best-practices-for-k8s:mainfrom Mar 6, 2026
Conversation
…ec G120 Extract replicaCountOrDefault helper to eliminate duplicate nil-check logic in CheckPDBIsValid and CheckPDBIsZoneAware. Collapse nested if in isZoneAwareForDraining. Hoist duplicated generateStatefulSet closure to a shared package-level function in statefulset_scaling_test.go. Add http.MaxBytesReader to webserver runHandler to prevent potential memory exhaustion from unbounded form data parsing (gosec G120).
sebrandon1
force-pushed
the
simplify/deduplicate-pdb-and-test-helpers
branch
from
3d9a7ba to
82ec785
Compare
Collaborator
|
from change #3506: |
sebrandon1
merged commit 3f8217c
into
redhat-best-practices-for-k8s:main
45 checks passed
Collaborator
|
from change #3506: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
replicaCountOrDefaulthelper intests/observability/pdb/pdb.goto eliminate duplicate nil-check logic betweenCheckPDBIsValidandCheckPDBIsZoneAwareifinto single conditional inisZoneAwareForDrainingfor cleaner idiomatic GogenerateStatefulSetclosure to a shared package-level function intests/lifecycle/scaling/statefulset_scaling_test.goTest plan
go test ./tests/observability/pdb/— all 18 PDB test cases passgo test ./tests/lifecycle/scaling/— all scaling test cases passgo build ./tests/observability/pdb/ ./tests/lifecycle/scaling/— compiles cleanly