fix: replace StatusSkipped with StatusCompliant in all checks#32
Merged
sebrandon1 merged 1 commit intomainfrom Apr 8, 2026
Merged
fix: replace StatusSkipped with StatusCompliant in all checks#32sebrandon1 merged 1 commit intomainfrom
sebrandon1 merged 1 commit intomainfrom
Conversation
Check functions should only return Compliant or NonCompliant. Skip decisions belong to the consumer (certsuite's WithSkipCheckFn), not the check implementation. When there are no resources to validate, the correct answer is Compliant (no violations found), not Skipped. Replaces 96 StatusSkipped returns across all check categories with StatusCompliant. The StatusSkipped constant is retained for backward compatibility but is no longer used by any check function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
The certsuite PoC migration (certsuite #3554) revealed that StatusSkipped returns cause the certsuite to record checks as skipped in claim files, which QE tests interpret as failures.
Test plan