Bugfix/crds disabled subchart #314
Closed
+1,350
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extract the existing "chart-0.1.0-v3.with-crd" and add it as a dependency of this chart. Installing this chart does not install any CRDs, since the condition for the chart is false. However, the NotContainCRDs check fails, since it doesn't take the condition into account.
Process dependencies according to chart values to remove unused subcharts, so any CRDs they may contain are not taken into account.
Contributor
Author
|
I created this draft PR with a reproducible test case, but I can also open an issue separately if preferred. To reproduce the failure on the first commit, I built the podman run --rm -it -e KUBECONFIG=/.kube/config \
-v "${HOME}/.kube":/.kube:z \
-v "$PWD/internal/chartverifier/checks/":/charts:z \
"quay.io/redhat-certification/chart-verifier:be2cebd" \
verify /charts/chart-0.1.0-v3.with-subchart/testchart/Running the same command on the last commit passes the "no CRDs" check: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent disabled subcharts containing CRDs from causing tests to fail.
Add a test chart which initially fails, since it contains a disabled subchart with a CRD.
By explicitly processing the dependencies (a workaround for this Helm issue), the check for CRDs passes.