Skip to content

Conversation

@caxu-rh
Copy link
Contributor

@caxu-rh caxu-rh commented Jul 9, 2025

  • Upgrade to golangci-lint v2
    • Migrate configuration file
    • Bump version used in Makefile
    • Address lint issues, remove unused nolint directives
  • Upgrade to Go 1.24
    • Bump version in go.mod
    • Bump base image version in Dockerfile

Go module dependencies will be automatically handled by Dependabot in one or more follow-up PRs.

caxu-rh added 2 commits July 9, 2025 10:56
@caxu-rh
Copy link
Contributor Author

caxu-rh commented Jul 9, 2025

     - check: v1.1/images-are-certified
      type: Mandatory
      outcome: FAIL
      reason: 'Failed to certify images : registry.access.redhat.com/rhscl/postgresql-10-rhel7:1-161 : bad response code 400 from pyxis request : https://catalog.redhat.com/api/containers/v1/repositories/registry/registry.access.redhat.com/repository/rhscl/postgresql-10-rhel7/images'

@mgoerens
Copy link
Contributor

mgoerens commented Jul 10, 2025

@caxu-rh To me that looks like an intermittent error, I've retried the pipeline but got another error:

Traceback (most recent call last):
  File "/home/runner/work/chart-verifier/chart-verifier/chart-verifier/ve1/bin/release-checker", line 8, in <module>
tarball_base_name=chart-verifier-1.13.12.tgz
    sys.exit(main())
  File "/home/runner/work/chart-verifier/chart-verifier/chart-verifier/ve1/lib/python3.9/site-packages/release/releasechecker.py", line 112, in main
    if check_if_only_version_file_is_modified(args.api_url):
  File "/home/runner/work/chart-verifier/chart-verifier/chart-verifier/ve1/lib/python3.9/site-packages/release/releasechecker.py", line 62, in check_if_only_version_file_is_modified
    filename = f["filename"]
TypeError: string indices must be integers
[INFO] Verifier tarball created : /home/runner/work/chart-verifier/chart-verifier/chart-verifier/chart-verifier-1.13.12.tgz.
PR_tarball_name=/home/runner/work/chart-verifier/chart-verifier/chart-verifier/chart-verifier-1.13.12.tgz
Error: Process completed with exit code 1.

I believe I have identified the issue (another intermittent issue, due to GitHub timeouts), and am working on a fix. (EDIT: see #513 )

I will now re-re-try the pipeline.

Copy link
Contributor

@mgoerens mgoerens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@komish komish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@komish komish merged commit e491eee into redhat-certification:main Jul 15, 2025
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants