allow email-notifications on the bastion host #328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| include: set_facts_.yaml | ||
| # ERROR! [DEPRECATED]: ansible.builtin.include has been removed. Use include_tasks or import_tasks instead. This feature was removed from ansible-core in a release after 2023-05-16. Please update your playbooks. | ||
| # CentOS Stream 8 | ||
| import_tasks: set_facts_.yaml |
Collaborator
There was a problem hiding this comment.
lets stick with include_tasks, as you have used it below as well (or whichever is more convenient, but lets keep everything in sync)
| msg: | ||
| - "Please run /usr/local/bin/helpernodecheck for information" | ||
|
|
||
| - "Please run /usr/local/bin/helpernodecheck for information" |
Collaborator
There was a problem hiding this comment.
Suggested change
| - "Please run /usr/local/bin/helpernodecheck for information" | |
| - "Please run /usr/local/bin/helpernodecheck for information" | |
|
|
||
| - name: Check postfix | ||
| command: postfix check | ||
| when: postfix_check |
Collaborator
There was a problem hiding this comment.
Suggested change
| when: postfix_check | |
| when: postfix_check | |
|
|
||
| - set_fact: | ||
| postfix_smtp_services: | ||
| - smtp |
Collaborator
There was a problem hiding this comment.
Suggested change
| - smtp | |
| - smtp | |
| sender: "openshift@{{ helper.name }}.{{ dns.clusterid }}.{{ dns.domain | lower }}" | ||
| to: "incoming@{{ helper.name }}.{{ dns.clusterid }}.{{ dns.domain | lower }}" | ||
| subject: Email By Ansible | ||
| body: Test successful No newline at end of file |
Collaborator
There was a problem hiding this comment.
Suggested change
| body: Test successful | |
| body: Test successful | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the email feature on the bastion host so that users can test Prometheus rules and Alertmanager notifications out of the box.
Given that the
ocp4-helpernodeproject already provides DNSMX Recordit was a no-brainer to include this as part of this helpful project.Please note that the code utilized was mostly obtained from the upstream postfix ansible-galaxy role [1]. However, found it too convoluted to use alone in addition to the ocp4-helpernode project. It is my opinion that this addition to the ocp4-helpernode will greatly help me and others to facilitate the setup to a more realistic test environment.
The details are as follow:
127.0.0.1& theopenshift4subnet192.168.7.0/24openshift&incomingwhich Alertmanager uses to connect and receive the email notifications - (required)./usr/sbin/nologinshell and locked password.postfix_filesorpostfix_confper the upstream project [1] if you desire.docs/email-notifications.mdfor how to get this up and working with minimal effort. So you can focus on testing and not having to figure out how to implement email on the bastion host.Tested on
RHEL-8.10andCentos Stream 8[1] - https://github.com/linux-system-roles/postfix