feat/fix: support multiple keys on same path for random secret#300
Open
13bscsaamjad wants to merge 1 commit intoredhat-cop:mainfrom
Open
feat/fix: support multiple keys on same path for random secret#30013bscsaamjad wants to merge 1 commit intoredhat-cop:mainfrom
13bscsaamjad wants to merge 1 commit intoredhat-cop:mainfrom
Conversation
Contributor
Author
|
@raffaelespazzoli if you can review this? Thanks in advance! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RandomSecret controller to support multiple secrets on same Vault path
Problem
Vault allows for multiple secrets on same path. RandomSecret controller has issue for when resources pointed to the same Vault path (via
spec.nameoverride), only the first resource would create its secret. Subsequent resources would reconcile successfully but won't create their secrets in Vault, leading to confusing behavior where the resource showed no errors but the expected secret was missing.Solution
CreateOrMergeKVmethod to merge new keys (secrets) into existing Vault secrets instead of skipping creation.password, another forusername...).The changes are backward compatible and works with both KV v1 and KV v2 secret engines.
Solves #234 with an approach without breaking changes.